* Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build
@ 2007-09-13 23:28 aherrman
2007-09-14 0:53 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: aherrman @ 2007-09-13 23:28 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: Jens Axboe, David Howells, linux-kernel
Due to commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22
kernel build is broken if (CONFIG_COMPAT && ! CONFIG_BLOCK):
CC fs/compat_ioctl.o
In file included from include/linux/raid/md_k.h:19,
from include/linux/raid/md.h:54,
from fs/compat_ioctl.c:25:
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:40: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:48: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h:51: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:64: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_merge_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:78: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h: In bio_list_:
include/linux/raid/../../../drivers/md/dm-bio-list.h:90: error: dereferencing pointer to incomplete type
include/linux/raid/../../../drivers/md/dm-bio-list.h:94: error: dereferencing pointer to incomplete type
make[1]: *** [fs/compat_ioctl.o] Error 1
make: *** [fs] Error 2
So either revert that commit or better apply the attached patch to fix it.
Regards,
Andreas
--
Fix kernel compilation if CONFIG_COMPAT is selected but CONFIG_BLOCK is not.
This is needed due to commit
02a5e0acb3cb85d80d0fe834e366d38a92bbaa22
Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
---
drivers/md/dm-bio-list.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/md/dm-bio-list.h b/drivers/md/dm-bio-list.h
index 16ee3b0..3f7b827 100644
--- a/drivers/md/dm-bio-list.h
+++ b/drivers/md/dm-bio-list.h
@@ -9,6 +9,8 @@
#include <linux/bio.h>
+#ifdef CONFIG_BLOCK
+
struct bio_list {
struct bio *head;
struct bio *tail;
@@ -106,4 +108,5 @@ static inline struct bio *bio_list_get(struct bio_list *bl)
return bio;
}
+#endif /* CONFIG_BLOCK */
#endif
--
1.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build
2007-09-13 23:28 Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build aherrman
@ 2007-09-14 0:53 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2007-09-14 0:53 UTC (permalink / raw)
To: aherrman
Cc: dhowells, Linus Torvalds, Andrew Morton, Jens Axboe, linux-kernel
aherrman@arcor.de wrote:
> Due to commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22
> kernel build is broken if (CONFIG_COMPAT && ! CONFIG_BLOCK):
> ...
> ... or better apply the attached patch to fix it.
Acked-By: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-14 0:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-13 23:28 Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build aherrman
2007-09-14 0:53 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox