From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A40901EE039 for ; Tue, 3 Dec 2024 19:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733255711; cv=none; b=G7xXHk9sEzOnzwej+8R1WCeoWhVlYRDq0+9PRsxrB5MP/lF/TfJE8TwhQ8CAfPsEXtCLoKJVfeKYazkXy66xrBqEpeeBdSPZS+XDZMI0M+nIYlXg1gZyXu938EI+UUN89/I5XrqZ/+StiEi7NLPCY4ZhzKjtVPR9TlTq9YxPM80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733255711; c=relaxed/simple; bh=N5t+jpeo/Kd0Sj1FWBHjHrKzMTEommNT5RZDIB53iDc=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=KenekgrXUA36C58qBGudKECdGNf3ZkyGcC1QIgcLmPo3IgW+NyOQ7jwUGZaQa5iKHMgkUSbGSMGJa1mGoER1UzrIKYNgzHaKIw/JpgnLug8n0eYQRdYi7b17rZs2B0qYLkxWeuaCJn6LAYlKQRxSJSewzuW2dqz97U4iJrryLr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eX9FK8Ni; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eX9FK8Ni" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733255708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ij8FfaOcSnuZLJFev0ynSdcsTu+uvN40kQmxbAbwMnU=; b=eX9FK8NiUFf3rbV52sB44nsjUD39ynkU30mY/fChUw/9Og7m4hoBQ/Bzh26C+Uqp8/FHty mf6jU3IeacpVfbjavpxmurZ1DRJgjIoMKIyAY75k3hc4TRkgfmNwj5nh8NcW0XmWKJHaaH 55yEoGJ5oyJJZ62tC2olcY/jkCh2Hvk= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-k-VvebuwM727CyJ5S1BGkQ-1; Tue, 03 Dec 2024 14:55:04 -0500 X-MC-Unique: k-VvebuwM727CyJ5S1BGkQ-1 X-Mimecast-MFC-AGG-ID: k-VvebuwM727CyJ5S1BGkQ Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EF680190D5D3; Tue, 3 Dec 2024 19:54:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.48]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 20980195606C; Tue, 3 Dec 2024 19:54:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20241202194834.67982f7f@kernel.org> References: <20241202194834.67982f7f@kernel.org> <20241202143057.378147-1-dhowells@redhat.com> <20241202143057.378147-38-dhowells@redhat.com> To: Jakub Kicinski Cc: dhowells@redhat.com, netdev@vger.kernel.org, Marc Dionne , Yunsheng Lin , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 37/37] rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985] Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <726992.1733255693.1@warthog.procyon.org.uk> Date: Tue, 03 Dec 2024 19:54:53 +0000 Message-ID: <726993.1733255693@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Jakub Kicinski wrote: > On Mon, 2 Dec 2024 14:30:55 +0000 David Howells wrote: > > +static inline ktime_t us_to_ktime(u64 us) > > +{ > > + return us * NSEC_PER_USEC; > > +} > > Is there a reason this doesn't exist in include/linux/ktime.h ? > Given ns_to_ktime and ms_to_ktime already exist there adding a local > but very similarly named helper in a local file appears questionable. Yeah - I'll move it there. It's just that winding backwards and forwards through the patchset sucks if one of the patches modifies a major header. David