Re: [PATCH v3] selftests/resctrl: Fix non-contiguous CBM for AMD

[Shuah Khan <skhan@linuxfoundation.org>]

On 6/26/24 10:55, Reinette Chatre wrote:
> Hi Shuah,
> 
> Could you please consider this fix for inclusion into kselftests?
> 
> Thank you very much.
> 
> Reinette
> 
> On 6/11/24 3:18 PM, Babu Moger wrote:
>> The non-contiguous CBM test fails on AMD with:
>> Starting L3_NONCONT_CAT test ...
>> Mounting resctrl to "/sys/fs/resctrl"
>> CPUID output doesn't match 'sparse_masks' file content!
>> not ok 5 L3_NONCONT_CAT: test
>>
>> AMD always supports non-contiguous CBM but does not report it via CPUID.
>>
>> Fix the non-contiguous CBM test to use CPUID to discover non-contiguous
>> CBM support only on Intel.
>>
>> Fixes: ae638551ab64 ("selftests/resctrl: Add non-contiguous CBMs CAT test")
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>> ---
>> v3: Reworked changelong.
>>
>> v2: Moved the non-contiguous CBM verification to a new function
>>      arch_supports_noncont_cat.
>>
>> v1: This was part of the series
>>      https://lore.kernel.org/lkml/cover.1708637563.git.babu.moger@amd.com/
>>      Sending this as a separate fix per review comments.
>> ---
>>   tools/testing/selftests/resctrl/cat_test.c | 32 +++++++++++++++-------
>>   1 file changed, 22 insertions(+), 10 deletions(-)
>>

Applied to linux-kselftest fixes branch for 6.10-rc6

thanks,
-- Shuah