From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966357AbcIYMrR (ORCPT ); Sun, 25 Sep 2016 08:47:17 -0400 Received: from mout.web.de ([212.227.17.11]:61258 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966135AbcIYMrO (ORCPT ); Sun, 25 Sep 2016 08:47:14 -0400 Subject: Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces To: Sergei Shtylyov References: <06e7637c-f682-bfa2-82b6-47d071bd58c4@users.sourceforge.net> <52dd5000-2bda-a1b6-aa97-1868e1193d35@cogentembedded.com> Cc: netdev@vger.kernel.org, Karsten Keil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <727b14d4-7a3b-9de8-25d9-c3bf212f7c44@users.sourceforge.net> Date: Sun, 25 Sep 2016 14:47:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <52dd5000-2bda-a1b6-aa97-1868e1193d35@cogentembedded.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tLNU4Q85PyCxUkDwCo7Q9zWVu7tUUtJ3Z2uG6moKCTru2Clw9jb 3uWMwwJrf3xN71/ZYAyKG1/gHTPr6xSTLcVYj6yczTjI305tVtUJsug5IZ+ULSxfUrjNape Ms3UojnEC4+FPCkZlK9ICPgSaKiCbIQapOFvCwbo29bmSqAsq2nb6Rbfazl+Wi1562jLh49 JjYy9ZvvCOW4/HVJCB0WA== X-UI-Out-Filterresults: notjunk:1;V01:K0:uVw4qQeQ13A=:4E42z447UVx4goOc9le4/s b+IO8aeojyKnO+/hpuq1BR8sehRj9tf5HiG1H8Dr+JFR9YaWkIilVyUaIVthVpHHgNoWywHGf tsYayWMoEXwv3OI7nZs+AmyWHb4av5wtxRy4uN9OuPalAC8rrHkCvAc8CnrnkAUTgbDovYpPo oNXv9mrZPpFMsy6icc7REwcqnuynaNeJ4WHeoT7i4c/CZ2nRNw29Po6O+yl4arp3LhnUILM5J Zu+CQxIT2CwR+NKcgmJmCfV/d+uDpSC0r/ytZoGh0mJAwd2OJwFUlYj4+KKUpprblc5FIxnNk I85RqVlXZhli1yPgoBOL4xJGD8woV1TkB5DMqxdpRQd+OXgEbBfT6B1r0QzWOsDkvRl4nz1Gr G5KFo6zc+SVZntibjYL75uC0SJDBQ0H3W7nvJtOLxE1zxsR3eGyKnW53D+fnAcW7i+9tDDjp6 33nlxB9Rzf/Pqyk5dKaE589pypQYEgzeNRG94mCDQlssDuERCQB2e3FDw55ukyHS9/oTJl+Vy 2CaaJu2zSCSxDRPPAZpQ76R8VVyDPv2zc4uC/p3yqdauFOiwU0hcmtOKa5+/9RLFRSAUZtJND ManJdAyNQS3Wo+GAspho/VrmIEXuHokaVS/sEp6FFXUj21yohVhSfItJuo6UU+R/LoTtLyoa5 0xhQPLPUY3BhCI0czCMknyiaAGlf2m5wXxkqji+qmpjhnZJL8dP0FrQoNXhZ4xrRaACmAO+g8 sHl8Nj75jp4ojMO0uClL+i04sPOi51WYUxDAImiR681Zfp75srKiNJL+5T8F83Je9wzApRc0E 7srmz3Z Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> @@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg) >> if (debugmode) >> printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x (%s) cipmask=0x%x\n", >> card->contrnr, cmsg->Info, capi_info2str(cmsg->Info), card->cipmask); >> - if (cmsg->Info) { >> + if (cmsg->Info) >> listen_change_state(card, EV_LISTEN_CONF_ERROR); >> - } else if (card->cipmask == 0) { >> + else if (card->cipmask == 0) >> listen_change_state(card, EV_LISTEN_CONF_EMPTY); >> - } else { >> + else > > Indented too much. How do you think about an alignment of this "else" with the corresponding if statement three lines above? Regards, Markus