From: Jens Axboe <axboe@kernel.dk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: kernel test robot <lkp@intel.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kbuild-all@lists.01.org
Subject: Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header
Date: Wed, 7 Apr 2021 10:43:53 -0600 [thread overview]
Message-ID: <728ec7f8-310e-e478-bd53-8784392aee25@kernel.dk> (raw)
In-Reply-To: <YG3ddNiPdUgRmBZc@smile.fi.intel.com>
On 4/7/21 10:27 AM, Andy Shevchenko wrote:
> On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote:
>> On 4/7/21 10:03 AM, Andy Shevchenko wrote:
>>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote:
>
> ...
>
>>>> All errors (new ones prefixed by >>):
>>>
>>> Thanks, we need to include bits.h.
>>> (It passed my simple build, but appears I have no such driver included)
>>>
>>> Jens, I saw your message, should I send a follow up fix, or a v2?
>>
>> Let's just drop it, not worth it for the risk imho.
>
> Does it mean I may try again in next cycle?
>
> Because kernel.h inclusion seems to me too wrong there.
I don't mind taking it, but not on a hunch. If you send something
that has been thought about and went through full compilation, then
you can resend it.
--
Jens Axboe
next prev parent reply other threads:[~2021-04-07 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 13:47 [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Andy Shevchenko
2021-04-07 15:42 ` Jens Axboe
2021-04-07 15:51 ` kernel test robot
2021-04-07 16:03 ` Andy Shevchenko
2021-04-07 16:04 ` Jens Axboe
2021-04-07 16:27 ` Andy Shevchenko
2021-04-07 16:43 ` Jens Axboe [this message]
2021-04-07 17:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=728ec7f8-310e-e478-bd53-8784392aee25@kernel.dk \
--to=axboe@kernel.dk \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox