From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E8A3603E9 for ; Thu, 16 Apr 2026 08:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776327130; cv=none; b=Aea+nnSyBiC8NYoZLZ52cXsDTV2M7WUH2epFEH0ZOSE6Ok0KQOBYAMDJNiHVEDyhxV1nCu1GWW52J14gJ8Efz3+9bc7PERLlvMeTCwiInvbd/pTFDoyH51Urui/gBKfer14DQnz00nATynoHzU8rkfzIltfqONySjaa/pLU2o58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776327130; c=relaxed/simple; bh=4Hbe4aYfPwQJCdXwR7o/DQD63W4U9iXbnSh7ROQgS9o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O69VCL/nztGmKxj+Muq+OyQzUINX3WEa1JTZec9laRdzw4yKvVVH5rip1qp66yBirZ9EmCCRZ44gRK3uVEzjRraHpqrRvNeBTdmb8SoWzx/IxQWx5P9tVoyiThZJb4tJhid4gQ9zrlwcma1NBFb5qYJiGxNogFiJ9JAVvHYPKgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MB3xNR6K; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lG6EBcGx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MB3xNR6K"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lG6EBcGx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776327127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dCw/fk1scpcEI5fTg9Hp2YTuYcflg1hd7U/WW44L5U8=; b=MB3xNR6KYko5QQkOYxUURByIW6M7+RGW0jMdhSkO//sIJ33Pf/avp/ReSMjTo4gpsNajnj gFCF6phvPj5iSSQ76cb/4WvVa239KtGw2eYydiTgmxqkrm7aoxYAvZNOv7juZ5g/tASKYS ziqqCVSvhDnJssFkXvLkl96JsBdBQw0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-PI35hWIYNCGxGkbk5OgLDQ-1; Thu, 16 Apr 2026 04:12:06 -0400 X-MC-Unique: PI35hWIYNCGxGkbk5OgLDQ-1 X-Mimecast-MFC-AGG-ID: PI35hWIYNCGxGkbk5OgLDQ_1776327125 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d7a5b9678so3196921f8f.2 for ; Thu, 16 Apr 2026 01:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776327125; x=1776931925; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dCw/fk1scpcEI5fTg9Hp2YTuYcflg1hd7U/WW44L5U8=; b=lG6EBcGx0uv4/mvNVVBEaPQ8eQSbSZSARYoPm1rE313DYvmH2brypwjNiw9apnZTYn 8MxWCrBrDDS7j5BftjKmHoQd8/9lFVcWf3plL3uHkntyeF3V6Cr/wv7LZUoC47edeYDf Ws9tEeOSc9U7kAqHiBGizdIhNo+9wxj66dAQkX7SVJHTKiqitTVWbcYqjEU2koSGm/sY 9A8vCsV5kpZm/HhpehzDSuJP8n/nszVM7Uv4rlPtFOHzxHyu4DbxXVrus0zMrPENNXRf NsiMfCFENpzjfJvED/FCskaWV+uk/3stsQ4cZr3a0XSJgdCW1A42Y04jgLPWmiRHNwVv 8ASA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776327125; x=1776931925; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dCw/fk1scpcEI5fTg9Hp2YTuYcflg1hd7U/WW44L5U8=; b=ryq4mb2naZRh0Oouc8N8dpzG/7WmtgenibowLjIIjFMT136bZ6Rj1z+WB4v2GIuTzv plUipgf+oCpI036sO4+F3LgKEaceenf0plCyQ1nx3HU0MIQwkkIc9GCoW1f2lehy/lzP v5Q3jTJ57M+5fzZCia/uwEANUfdpPzj4v2n921gvd629Vs0IrHDI9rCUDlNo0EcLWs7e STp8U9JgbnLWscOuLQ0lLSsmWyd60pC/Q3cuH9IQXmhc5PghYj3rid0VCYljSkpdYzqr eEoeGaABPBTvZ7xiJorxInuxdUPsLB5KW68VbmuIIxJAGGJGcYdUz6MC8qder789AMnB u6zA== X-Forwarded-Encrypted: i=1; AFNElJ+UBCerHc3dxVDtCUd/XMqe0U2o5sCiUALwK1CzYBfNlwXWvQVkUFztMYfu/iYWCbOCw6iGxcWkasVeRVg=@vger.kernel.org X-Gm-Message-State: AOJu0YyKban7fwDJIFBZO70jvanxCHeOlp6TlwoP6N9s3pX0Qb6uzhOf 2NuUmiMgS6P8e6Lztl0WhOW2QqrXya6HNro/0p7W0riLgRMUN5N73yx8LE7qHlbwH61YXktQshj nhUBOTK8OJlBX+yHgalY+bkIbYAq7txbAJD3US+k9yulgVDcvjD/lDqzDxTBgrgAtew== X-Gm-Gg: AeBDiesaEPee9HuJeaM8ZNNeLmSQ164cbD8WKsHXdSy9fvq4J0yMwh6DPd6SfD2nx7q bQKbVxdDae7HA0I68ZtnoWznrbv3ZwDEYA9a2k9QJ//R/sod8uzFmJWwkfRRQoMa/PTWNuC04ES tQiGs1h/FzYEtpPZXqktk7qC7e+Wo8izoNNmDIEIGj/lFQ1U0rAV1HLn8nAcooaZOEIzu8rlVi4 SaWTeg0ujEGn1/iKnDO7x9xbO/eQ0x6YZXVS7IdLSHW8P65+4T84uQ+GfcCZpbhJoczhQdD5QLD EQVtYXUq3NUUHV7tyOey/le7ltYJVghigW6CUzXp6CJoLo4/UD0Eu35A7jRI3kF7LaAk1lXRaw0 kAyJLIUwJ7dWWk6TiIV0MAO4P2M/Wtc0YHHhXC8WZ3IYpDh7a128HeVeh3cWoOgzSLDs= X-Received: by 2002:a05:6000:2c02:b0:43d:75a2:44a1 with SMTP id ffacd0b85a97d-43d75a2463emr24016071f8f.47.1776327124798; Thu, 16 Apr 2026 01:12:04 -0700 (PDT) X-Received: by 2002:a05:6000:2c02:b0:43d:75a2:44a1 with SMTP id ffacd0b85a97d-43d75a2463emr24016016f8f.47.1776327124289; Thu, 16 Apr 2026 01:12:04 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.122]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3d5ea9sm11794717f8f.21.2026.04.16.01.12.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 01:12:03 -0700 (PDT) Message-ID: <72d1b0b7-c8df-463e-a2d9-bf5ff04ba33c@redhat.com> Date: Thu, 16 Apr 2026 10:12:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net,v2 1/1] net: stmmac: Update default_an_inband before passing value to phylink_config To: KhaiWenTan , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com, ovidiu.panait.rb@renesas.com, vladimir.oltean@nxp.com Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yoong.siang.song@intel.com, hong.aun.looi@intel.com, khai.wen.tan@intel.com References: <20260413020339.68426-1-khai.wen.tan@linux.intel.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260413020339.68426-1-khai.wen.tan@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/13/26 4:03 AM, KhaiWenTan wrote: > get_interfaces() will update both the plat->phy_interfaces and > mdio_bus_data->default_an_inband based on reading a SERDES register. As > get_interfaces() will be called after default_an_inband had already been > read, dwmac-intel regressed as a result with incorrect default_an_inband > value in phylink_config. > > Therefore, we moved the priv->plat->get_interfaces() to be executed first > before assigning mdio_bus_data->default_an_inband to > config->default_an_inband to ensure default_an_inband is in correct value. > > Fixes: d3836052fe09 ("net: stmmac: intel: convert speed_mode_2500() to get_interfaces()") > Signed-off-by: KhaiWenTan Since Jakub sent the net-next PR and forwarded the trees, this patch does not apply anymore. Please rebase and repost. You can retain Russell's reviewed-by tag. Thanks, Paolo