From: <Claudiu.Beznea@microchip.com>
To: <Codrin.Ciubotariu@microchip.com>, <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <alexandre.belloni@bootlin.com>, <sboyd@kernel.org>,
<Ludovic.Desroches@microchip.com>, <Eugen.Hristev@microchip.com>
Subject: Re: [PATCH] clk: at91: sam9x60: Don't use audio PLL
Date: Fri, 31 Jan 2020 10:42:06 +0000 [thread overview]
Message-ID: <72d97d68-690b-7f18-0dca-a5aa131e1c29@microchip.com> (raw)
In-Reply-To: <20200130174708.12448-1-codrin.ciubotariu@microchip.com>
Hi Codrin,
On 30.01.2020 19:47, Codrin Ciubotariu wrote:
> On sam9x60, there is not audio PLL and so I2S and classD have to use one
> of the best matching parents for their generated clock.
>
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> drivers/clk/at91/sam9x60.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> index 77398aefeb6d..0aeb44fed9de 100644
> --- a/drivers/clk/at91/sam9x60.c
> +++ b/drivers/clk/at91/sam9x60.c
> @@ -144,11 +144,9 @@ static const struct {
> { .n = "sdmmc1_gclk", .id = 26, .r = { .min = 0, .max = 105000000 }, },
> { .n = "flex11_gclk", .id = 32, },
> { .n = "flex12_gclk", .id = 33, },
> - { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 },
> - .pll = true, },
> + { .n = "i2s_gclk", .id = 34, .r = { .min = 0, .max = 105000000 }, },
> { .n = "pit64b_gclk", .id = 37, },
> - { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 },
> - .pll = true, },
> + { .n = "classd_gclk", .id = 42, .r = { .min = 0, .max = 100000000 }, },
> { .n = "tcb1_gclk", .id = 45, },
> { .n = "dbgu_gclk", .id = 47, },
> };
Please remove also the pll member of:
static const struct {
char *n;
u8 id;
struct clk_range r;
bool pll;
}
> --
> 2.20.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2020-01-31 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 17:47 [PATCH] clk: at91: sam9x60: Don't use audio PLL Codrin Ciubotariu
2020-01-31 10:42 ` Claudiu.Beznea [this message]
2020-01-31 11:51 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d97d68-690b-7f18-0dca-a5aa131e1c29@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox