From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755456AbcIJJoO (ORCPT ); Sat, 10 Sep 2016 05:44:14 -0400 Received: from mout.web.de ([212.227.17.12]:64595 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbcIJJoL (ORCPT ); Sat, 10 Sep 2016 05:44:11 -0400 Subject: [PATCH 06/30] ACPI-processor: Move a success indication in acpi_processor_preregister_performance() To: linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <72f31d34-3efd-346d-1738-a57dea9df710@users.sourceforge.net> Date: Sat, 10 Sep 2016 11:44:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7MCtOy5HFx2yNruYWM6dInv0xpqt+R8p1/xH9awJHk2GSTw0uaE ZOaoBCpsvS6vzmhVYNUcESNHVVuNEFFnKysqadzc8sAwQpbKcTLKyreiM8YhQ211wHVbguM ePUnCiPu6crvKWS8OG7CD25yQh2ZBKoBKTWQFqgIPCXN+7TrL2RTq2IYCQYS9GtzYDqxeh6 H96vgsxUTVAN8AdTS4lFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:W9W72t6D70k=:ybHkkeQcsEZKBQMcxO2ZUp CuaP6WfWBj6TMd0B1qwZQdiHE9cKsYMwpZUTaMehYig0SvxNaOJTDYt6+45kjk5PlqCT0x8Rn dgJqokSBE41LikY/8c/Kd90PdDgLH9R98G3UDWBLy0A348QQqa4hXAndKW5oxN9ORwrf7pPVt ROvlgN93v2Sz2s4fYRswGletnA0jJyKzTG4yw+v+zTc3aqFGhbIGe/uFiHUhqkh/G1mgASgzG FE433WIWx9pZCykXCtOKDSCZDzBt+MaX8R63Uln0sCz5f5iX4af89xqavjogiHBLQhEG0l21c 1PBH1QWoP41TGa6+9ka1UkohyS/8NcihVTGX/faBPyFJuzfpeVF9wNbU4cEflksudT00jBstZ 8z6U45KYyvSsholD8wYnZ0XzgywPJHrEIMCyL8pcrZP/k9ERtG9pbs/IgI9yNwd25P5UCeV+T zuy+cwvtWBw38TY+K5leKQpQX3EE5w02Ko5aGawyvCRq8iv+pbPKWr9cBFF9O8nGAi2C8w7Rz fEFaOYjzj388YDm8urveeTSWCHjQvcfQp+JIquOwm4iahTwNAqj4pZdBamfZd2k2TkDxzyiNz aRABGBH1WBb+KiD9fh2yxthlk7qssfA3lWE5MPEBD9jUsb66g8ZIbySo7l6NC52cRvHE++3mc 0xDuI2ApHzkrISKdm23WuItwmPZ1UttyYkokgYdEvc5u3d3/zVxRSbWL1OLMjGptC6HENiKOw dhm8f+90yDGL0QzfvdE/ygweKOFvueLmNseazjv7VEgEZJTgJEBDAI1hze7Ol0BfJRrIN8IVy +gEetd4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 6 Sep 2016 13:03:56 +0200 The local variable "retval" was initialised with a zero at the beginning as an indication for a successful function execution despite of the possibility that following function calls could fail. Move the desired assignment down to the source code place where some system clean-up is performed. Signed-off-by: Markus Elfring --- drivers/acpi/processor_perflib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c index 2fc82e7..417e181 100644 --- a/drivers/acpi/processor_perflib.c +++ b/drivers/acpi/processor_perflib.c @@ -595,7 +595,7 @@ int acpi_processor_preregister_performance( struct acpi_processor_performance __percpu *performance) { int count_target; - int retval = 0; + int retval; unsigned int i, j; cpumask_var_t covered_cpus; struct acpi_processor *pr; @@ -719,6 +719,8 @@ int acpi_processor_preregister_performance( pr->performance->shared_cpu_map); } } + + retval = 0; clear_cpu: for_each_possible_cpu(i) { pr = per_cpu(processors, i); -- 2.10.0