From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756154AbcJVUs4 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 22 Oct 2016 16:48:56 -0400
Received: from mout.web.de ([212.227.17.11]:59528 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754877AbcJVUsw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 22 Oct 2016 16:48:52 -0400
Subject: Re: [PATCH 6/6] IA64-sn2_smp: Combine two seq_printf() calls into one
 call in sn2_ptc_seq_show()
To: Joe Perches <joe@perches.com>, linux-ia64@vger.kernel.org
References: <8daf03e1-5f6d-fc3b-c2db-397e6d4a9a1c@users.sourceforge.net>
 <c3e12189-6122-e806-6cb2-b2518e64e983@users.sourceforge.net>
 <1477166856.3817.4.camel@perches.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Borislav Petkov <bp@suse.de>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>,
        Ingo Molnar <mingo@kernel.org>,
        =?UTF-8?B?SsO2cmcgUsO2ZGVs?= <jroedel@suse.de>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Robert Richter <rrichter@cavium.com>,
        Robin Murphy <robin.murphy@arm.com>, Tony Luck <tony.luck@intel.com>,
        Toshi Kani <toshi.kani@hpe.com>, Vineet Gupta <vgupta@synopsys.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <72f6fc41-9bf8-2eef-848f-8eefba7dade6@users.sourceforge.net>
Date: Sat, 22 Oct 2016 22:48:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1477166856.3817.4.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:CdPdSEvcbhvNHqJa2ZxO53gJxXQ5zktTYka+TmVQGZ5FmPzIL4G
 2Nz5tPS9tBH7ybwMV6x6aGbBEfz6dMUaA10IjpnccVkPyZ13LTv9YZoPHOyYDQMzxznzCN2
 PZEKdow8CiEGWH09qH0DSDamquBfUWWKzW+53KJBFXddEGFA/BvzjLIi7Dv1wL6ghQ8Ry3q
 GA0tBFKmHWiZxiW08ue8g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:KYFXycDUPhU=:OMVzZuEmIEUnDsFWpWhTIA
 8cNSqgYsRPEJEc+4/Bed2Cap9ytiEokc8galGWHx/aP88BYipcRbsWPTiScW5DG/gT9Mu23T7
 Cb4CZniV1vlcdhCOpSQZWu9fK9fkNY9fcvKOxdRSftQFzkr8KagooCL+2CPZ1qZ+w0DypZuzz
 HI8++NRkgxt0PO4QjdtwFpdMSNOycQ1KnNf/ANneNoUx+TRGUDXOxRSSxKK83M67t4x14uM0U
 6sdxb4nLXPTg65uPbM8aE8D/wPKJTLjE7AR/WuBxpiXWL90AsROCewkuwjiGth/lhByQubYLe
 QEnvw16a2d6ixVwOIQp2o15US92wdHuimgrgIyzVVxq/g073E1GzhULSVBnKzAW/B0L698kOQ
 a7Vxm11P7V9BxKwVTV6QZvcWz0Fx9kHZBOlwLCINmL0Auklyw6yJtI5EPBTRQrRyMkUt+lJMK
 uEYFM3ANaw68v2+I7n063yroPzy0sLDX2HggnTZcvIZOcX65ShW/ehYYdGAmkXEwU0JoQNZ8X
 AYalBWetzz2k3qqrHbA8hdhaJPOURAB0RtBYOH8F+DoHQAjmw/cvdwdHpOdOOS9doHhxcy4Fu
 ezqabj/Gf0nteNr29GSit2JlIatW+AFBVhuuAYMT521ZCkjjxmJBwMgRpx8gbBm05rUUnNf8c
 Ca/uISBs67Wk4Wl6M/DHESBgbgyDVfhDUxu+nHhVIahTF4eBKJtwnzIFyTZTVQHezTW4+0cjs
 RCqyW3i1U8tdvm629fxidY18P6eNE4oJ3dsJv04sOKNEQijS+Z0VNlZSUzNTbWdtTxNbNReAv
 l5rdDLh
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -494,12 +494,11 @@ static int sn2_ptc_seq_show(struct seq_file *file, void *data)
>>  	int cpu;
>>  
>>  	cpu = *(loff_t *) data;
>> -
>> -	if (!cpu) {
>> +	if (!cpu)
>>  		seq_printf(file,
>> -			   "# cpu ptc_l newrid ptc_flushes nodes_flushed deadlocks lock_nsec shub_nsec shub_nsec_max not_my_mm deadlock2 ipi_fluches ipi_nsec\n");
>> -		seq_printf(file, "# ptctest %d, flushopt %d\n", sn2_ptctest, sn2_flush_opt);
>> -	}
>> +			   "# cpu ptc_l newrid ptc_flushes nodes_flushed deadlocks lock_nsec shub_nsec shub_nsec_max not_my_mm deadlock2 ipi_fluches ipi_nsec\n"
>> +			   "# ptctest %d, flushopt %d\n",
>> +			   sn2_ptctest, sn2_flush_opt);
>>  
>>  	if (cpu < nr_cpu_ids && cpu_online(cpu)) {
>>  		stat = &per_cpu(ptcstats, cpu);
> 
> Please think more.
> 
> printf has to inspect character by character looking for
> a vsprintf % character and 0 termination.
> 
> seq_puts does a strlen then memcpy.

Would you prefer to use this function also at this source code place?

Regards,
Markus