From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754838AbbLAPeQ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Dec 2015 10:34:16 -0500
Received: from mout.kundenserver.de ([212.227.126.134]:52432 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751989AbbLAPeN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Dec 2015 10:34:13 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tomasz Figa <tfiga@chromium.org>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Mark Brown <broonie@kernel.org>, Kukjin Kim <kgene@kernel.org>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH 03/10] gpio: samsung: move gpio-samsung driver back to platform code
Date: Tue, 01 Dec 2015 16:33:24 +0100
Message-ID: <7302923.ORKinVl6Ne@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <565CEB0A.4090107@samsung.com>
References: <1448467615-447097-1-git-send-email-arnd@arndb.de> <1448467615-447097-4-git-send-email-arnd@arndb.de> <565CEB0A.4090107@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:lrFcKMvUGQwmAzy/9CI+vStQ6Z+6e0eT35M/BoWZ/uafvuliSpp
 IKkBeiRNyqT7MOIqm8S++4DtfMZDUFL3a+M8eQAENQy0ZitcMPnLuCsToWiuzlg/vvCHBnB
 qF+Rw5gaWKmSppKvaj+4NInwT/KW142C8K3VPPzABYgRQoYhMS8MEVjYFeDimcizOdmYENI
 cuYM3aF9Rsfn4Keg6qdlw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:RzNzIt3soDE=:DQCp5nu418bTUTF6SwycYg
 sRu/gLtdNb8rr5Fd81M7M64QVYsH7ih+bvIATLzPRk/6TJqE6Ipv7JiRuG2jaReGdhOUEyksm
 hs5GpvO4XanfZcoAWM0UUH4Zakk3wtUuTbTZM8mokXQ7ByHgY0mzhOltneGuD3HqOWYf/hFWG
 KMJ+/afPbEGqmHkXVl1yse8ydzii0HrSt5elcoikTFfzwtOxiIs0zXq/reoKpG60gnZ3DoyBI
 EL1bPmcRIB0TlNr6neaATfiyRG3A8DApornfGpNuZvYAC9FIzRZN9tXQX3lelOUV7FI5bYqux
 iQY+qMh6SAm7IEgrRIBaj1aRo/oxVkFx6hgo1QMjPtB/zyTMaXzNhMpYl3d5vXum48yRcUDsn
 ytPBESsEoRVHSSD0oL47TNljPgK9H1cv12h0OwxSbMuGrpltqbv++TSg9GIa412v617A+6V5O
 wm1xyQLE/HCwcpkqScd371sA25+0+/Scg++FuckgOWEZrGL+lYzirbQ0X+SjpuDZdRSo3MUbc
 WrLyTH8vPGhVu1CmP4xsZgmIAxbEzzuUVlWDHKWV+xJGkL3BV4qbgtpg6weT9PXAC3rsJow81
 lDFVGX4lMesQD2ScaAChuekBvC3Y17zy/IPcsaQX9HZnwTDVi7vnLJgAIK0tOwuIcmucEyjRz
 aEBm5iMhU04DX9FYSdmOQDMNFrQoxzLSkp5pgV5BMlQItjfvkk45k0SHHzC7gzyULPK2X8Mdg
 uwMfDG41DfCzgZTX
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 01 December 2015 09:34:18 Krzysztof Kozlowski wrote:
> On 26.11.2015 01:06, Arnd Bergmann wrote:
> > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> > index 57729b915003..83697414bfa0 100644
> > --- a/arch/arm/plat-samsung/Kconfig
> > +++ b/arch/arm/plat-samsung/Kconfig
> > @@ -294,6 +294,9 @@ config SAMSUNG_WDT_RESET
> >         Compile support for system restart by triggering watchdog reset.
> >         Used on SoCs that do not provide dedicated reset control.
> >  
> > +config GPIO_SAMSUNG
> > +     def_bool SAMSUNG_ATAGS
> > +
> 
> I think this should be put inside "if SAMSUNG_ATAGS" section, just
> before SAMSUNG_PM_GPIO (with default=y?). It makes more consistent with
> rest of the options depending on ATAGS.

Good idea, changed that now.

> Rest seems fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Thanks,

	Arnd