From: Oliver Neukum <oneukum@suse.com>
To: Greg KH <greg@kroah.com>, Eric Naim <dnaim@cachyos.org>
Cc: Taylor Hewetson <taylor@exponent.digital>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: sanitize hid->uniq against non-printable bytes
Date: Thu, 23 Apr 2026 11:49:02 +0200 [thread overview]
Message-ID: <7312e4df-9eab-4678-bd40-ae7187a53827@suse.com> (raw)
In-Reply-To: <2026042330-underarm-reusable-effa@gregkh>
On 23.04.26 11:29, Greg KH wrote:
> On Thu, Apr 23, 2026 at 05:55:00AM +0000, Eric Naim wrote:
>> On 4/18/26 3:14 PM, Greg KH wrote:
>> [1] https://github.com/systemd/systemd/issues/41339#issuecomment-4266429563
>
> It's either up to the kernel, or every single userspace program that
> reads the strings from a device. Might as well do it in one place,
> right?
No, because that puts the assumption that user space is not interested
in what the device actually returns and uses these strings just
for printing.
Eg. you can no longer use this in a udev rule.
Regards
Oliver
next prev parent reply other threads:[~2026-04-23 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 2:58 [PATCH] HID: usbhid: sanitize hid->uniq against non-printable bytes Taylor Hewetson
2026-04-18 7:14 ` Greg KH
2026-04-23 5:55 ` Eric Naim
2026-04-23 9:29 ` Greg KH
2026-04-23 9:36 ` Eric Naim
2026-04-23 9:49 ` Oliver Neukum [this message]
2026-04-23 14:03 ` Alan Stern
2026-04-18 19:08 ` USB: core: sanitize string descriptors against C0 control characters Taylor Hewetson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7312e4df-9eab-4678-bd40-ae7187a53827@suse.com \
--to=oneukum@suse.com \
--cc=bentiss@kernel.org \
--cc=dnaim@cachyos.org \
--cc=greg@kroah.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=taylor@exponent.digital \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox