From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Poovendhan Selvaraj <quic_poovendh@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
jassisinghbrar@gmail.com, catalin.marinas@arm.com,
will@kernel.org, shawnguo@kernel.org, arnd@arndb.de,
marcel.ziswiler@toradex.com, robimarko@gmail.com,
dmitry.baryshkov@linaro.org, nfraprado@collabora.com,
broonie@kernel.org, quic_gurus@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: quic_srichara@quicinc.com, quic_gokulsri@quicinc.com,
quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com,
quic_arajkuma@quicinc.com, quic_anusha@quicinc.com,
quic_devipriy@quicinc.com
Subject: Re: [PATCH V4 4/5] arm64: dts: qcom: ipq9574: Add SMEM support
Date: Tue, 14 Feb 2023 08:54:17 +0100 [thread overview]
Message-ID: <732e0d0a-86ee-a636-62b0-ee3af75d00a2@linaro.org> (raw)
In-Reply-To: <20230214051414.10740-5-quic_poovendh@quicinc.com>
On 14/02/2023 06:14, Poovendhan Selvaraj wrote:
> Add the required nodes to support SMEM
>
> Changes in V4:
> - Added required nodes for smem support
>
> Signed-off-by: Poovendhan Selvaraj <quic_poovendh@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 898d7ce3f28d..2b41416d7f91 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -102,11 +102,17 @@
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> -
No improvements here. For the third time.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-14 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 5:14 [PATCH V4 0/5] Enable crashdump collection support for IPQ9574 Poovendhan Selvaraj
2023-02-14 5:14 ` [PATCH V4 1/5] dt-bindings: scm: Add compatible " Poovendhan Selvaraj
2023-02-14 7:54 ` Krzysztof Kozlowski
2023-02-14 5:14 ` [PATCH V4 2/5] dt-bindings: mfd: Add the tcsr " Poovendhan Selvaraj
2023-02-14 5:14 ` [PATCH V4 3/5] arm64: dts: qcom: ipq9574: Enable the download mode support Poovendhan Selvaraj
2023-02-14 5:14 ` [PATCH V4 4/5] arm64: dts: qcom: ipq9574: Add SMEM support Poovendhan Selvaraj
2023-02-14 7:54 ` Krzysztof Kozlowski [this message]
2023-02-14 5:14 ` [PATCH V4 5/5] firmware: scm: Modify only the DLOAD bit in TCSR register for download mode Poovendhan Selvaraj
2023-02-14 12:57 ` Srinivas Kandagatla
[not found] ` <b5135d69-3783-8147-bda5-8131cea726f7@quicinc.com>
2023-02-15 15:17 ` POOVENDHAN SELVARAJ
2023-02-15 15:17 ` Srinivas Kandagatla
2023-02-15 2:34 ` [PATCH V4 0/5] Enable crashdump collection support for IPQ9574 Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732e0d0a-86ee-a636-62b0-ee3af75d00a2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox