From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758909AbbJIScW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2015 14:32:22 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:59987 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753723AbbJIScU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2015 14:32:20 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Robin Murphy <robin.murphy@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Jon Medhurst <tixy@linaro.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        device-tree <devicetree@vger.kernel.org>,
        LAKML <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] PCI: Add quirk for PLDA's XpressRICH3 host bridge class.
Date: Fri, 09 Oct 2015 20:32:07 +0200
Message-ID: <7335872.olmykfZgj7@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1444409849-5685-3-git-send-email-Liviu.Dudau@arm.com>
References: <1444409849-5685-1-git-send-email-Liviu.Dudau@arm.com> <1444409849-5685-3-git-send-email-Liviu.Dudau@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:jcOWKEVsWtZEeytMPpJcLm3QqZvBfl8g5jb0Zi6rKIIUnxJWMKL
 VNl+r9fu5tkLkrrAu4xGE3kKR9bGedJeAgQ54m5YkcVtTTbBb0tWsvwB7el0yMKpVrL14pL
 B7D/VCYkzAovQkGfLLl3XzbMsesBS+PLAGGdK28RQEGyCQApmMTpnV0+YH2HLGLbqzvYgJe
 JQ/06NRu4p9DFKCaHlR1A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:RF9IeHTyWxY=:Ej5JoWWJTqvHfSh2ORqOxF
 Elyt/cFUDZGLIyawsRd1p6Ayt7eJsxfsJzowVqWw4j1DcfaWwHMlTLWO6L3aDejd08DSym8so
 o+e15zYbaVXPb0OBcq5vL93kua2LbsQHPLbQNgDpgtjBSU6wjAI+3lGlyUntwZrz6sH4yse+i
 EWe7dS6bnlOrxfs7QgCRKXQf/dKqW6TI42gKKrQsOU0y8Uq+9/9vuB9ISLqfu1esL6S9n8gS/
 3NBYhms/wPSC387ZM3s7HiU5SUW5ZGzgh8lZTYYPX7Bh+YCZRK2nEsQ8BkizSRKr/kzQBkXNw
 OFRPJ1JGFZCFLVocKd/HG2Zj/j87wYKH9o7sGAGgTUkpA5j1u+WeXFd7IN0ty+QhLbj2uPspE
 8TKBEmCxiMIykNg6P94gSKJAg/VBAp+nOJRALNCIZiYgREScEkZ8pHnetyE6hkhnf3to7RvXg
 hJrOKxnuWHsLJ15t5h25SzDRQ/+P91FZ6MaEmuvanLr1mBSXuQ3BxJM0Olg9Vs62fmNItbtaA
 9q1atjPUjS8084261Ro/UMhmOcGOPNzQAZCOqquDsUONzv794YKeLvifvTowThoY9imCSxGux
 Ctc/FGtL+D5xSB66pjuN5RFseUnhdbl0ouDx69rCx4nyrIEgM5EMffWKvjoUd5TlEqQrihBn2
 i11cmKzEAMexxHyUZfSpzpmPv5FjEkBzdM67TEFBSbmeN/+07KKaRIL5uPgAWiR1YXuXdQ5MV
 qx6Fss9lfyo/C2wN
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 09 October 2015 17:57:26 Liviu Dudau wrote:
> +/*
> + * The PLDA's XpressRICH3 doesn't describe itself as a bridge. This is required
> + * for correct/normal enumeration.
> + */
> +static void xr3pci_quirk_class(struct pci_dev *pdev)
> +{
> +       pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_PLDA, PCI_DEVICE_ID_XR3PCI, xr3pci_quirk_class);
> 

Are you sure that this device ID is only used for the host bridge, not
for related devices in endpoint mode?

While we don't support PCIe endpoint drivers at the moment, it might
happen at some point and then things break when someone tries to
plug a machine with this ID into a Linux host.

	Arnd