Re: [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc

Marc Zyngier
2020-01-28T10:58:34Z

On 2020-01-28 08:08, Makarand Pawagi wrote:
> ACPI support is added in the fsl-mc driver. Driver will parse
> MC DSDT table to extract memory and other resorces.
>
> Interrupt (GIC ITS) information will be extracted from MADT table
> by drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c.
>
> IORT table will be parsed to configure DMA.
>
> Signed-off-by: Makarand Pawagi <makarand.pawagi@nxp.com>
> ---
> drivers/acpi/arm64/iort.c | 53 +++++++++++++++++++++
> drivers/bus/fsl-mc/dprc-driver.c | 3 +-
> drivers/bus/fsl-mc/fsl-mc-bus.c | 48 +++++++++++++------
> drivers/bus/fsl-mc/fsl-mc-msi.c | 10 +++-
> drivers/bus/fsl-mc/fsl-mc-private.h | 4 +-
> drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 71
> ++++++++++++++++++++++++++++-
> include/linux/acpi_iort.h | 5 ++
> 7 files changed, 174 insertions(+), 20 deletions(-)

A general comment when you do this kind of work:

Do not write a single patch that impacts at least three different
subsystems. As it is, it is unmergeable.

Now the real question is *WHY* we need this kind of monstruosity?
ACPI deals with PCI, not with exotic busses and whatnot. If you want
to be creative, DT is your space. ACPI is designed to be plain and
boring, and that's how we like it.

Thanks,

M.
--
Jazz is not dead. It just smells funny...