From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BBAA3B6350 for ; Mon, 30 Mar 2026 14:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774880511; cv=none; b=g/zVp3BWzK7vSt/8npOhk1wAya5APNd2nz1b0eib326Z6lusuXAbZgDQdrXSsDY9tcAU+pwsydfd/mPhygUAJgEjzNLu3PJxI6WMJvdlC+t/dNM/gZsHkWPV6dU3XBj+jEvU0Z2dgUb/5PrdB55PpJdy6hpaFbJe1B2eFWfcOVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774880511; c=relaxed/simple; bh=xPYYFffO2JvL6Gyrx07KGnUt/pBCCiZo+BiSrblUBW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YLdgIJtQdkxH14kFGHZlufpBran4hWGiGNe4XtgF84hUQeoJ2cZqjI1oDevZTiM8p4ljHiCPSuoq5K55IkZ4vojwvNmvoQYuqsBTOJzWe022gwtexD1TjBS6tFpFg6b0P7Wv+wH1P0cxffA5E6XHETrAkSFvi0xyKo/XnfkveBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z1LGKUqJ; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z1LGKUqJ" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43cf5fbacc9so946914f8f.1 for ; Mon, 30 Mar 2026 07:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774880509; x=1775485309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3gI1060qWAxguxfqLo7d74lXelCuf/bPUdPr59uzbe0=; b=Z1LGKUqJHhzZvm2vldcEXaFUSe10lyX1VDaRVravL1to6Szmr2dBa03ryCVXDXpmoL Rod4OWYGQceh1GUlrFS0NEB0iPuWkDsS4AdBkt+epjzZvXMbo4KDazavabvQXa/DIE3J x6fmSCm5eNT5kbYpPXaXApQQ3rCKGVyljwPE8yhaPt9jULFF0tD7puwyISa8iScpworF 7JPf7l2Afl+nDatnqDNay558/f6UvwHgPU81UPdV4PTd2vJkWjQOpMcWONRkdyqAElO9 Vi6XQC2knMK8bvdjn2ZjqWHcFmr4Ww44Unb70ys/y4IlLiSj4RuLQv1Ao90/4IQ5xOAf CMBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774880509; x=1775485309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3gI1060qWAxguxfqLo7d74lXelCuf/bPUdPr59uzbe0=; b=k6KXHDwuUtu/yobqb+HcuYI51ypNBb8Sz82va1vfvlFvV3GtWIoG+wbA1k25hGsqVy 6XDe0VSeCXpo54eij6iLxMHIpJf00GCJzrhDRQTy+xJ8VMlJwKFhMHuJuJAUGExqwQzf 4MbYjKrdCD8ABN3eN6Y4wXBze+xM8jUuVZlBiYLwdXxJL599XV9T9EV90hjV25lzMoUC T4olwWNZ5bZ97aaSmweaCo3/wvrsDyZN1eRP2vg8f+fr3z7e+2r7k2h7fkt3X0Ev91E8 RPdV39FiaSJ1W0/a3ZAuPlMsmxA+WZGm1ZLoWwKpX29ygKyjj/d59gWmNRW3hVwhU76v rSxQ== X-Forwarded-Encrypted: i=1; AJvYcCWvR7aLe2ws84Z38DrhSIH6QEqxuCSOk7mdOjEK6tCL02KiWiDaPaCU9lzHuIieQzDEtu0kQ6ZiAio2xdM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/Nm0JCTuBP7aYJTa22k0pLEfaiLmNh3W1T0o2H+rFdyaUyPKI aO58rUc9wNQo81evaCQp9R7PyewvsNH1c34bokkUUfumW2qYkdb/7ugJ X-Gm-Gg: ATEYQzwGS0n7Br5GmbX9w7JMcn0oodleHcMDZ7RwYDM0IS7AjOueugsU2imisv248// 4RxapzVry9LhDA2OE9asyv7n5gOEoTqa88ys+xpjipEcbzT+SLvseg18fntfj4uLwD0fUC6Dn88 UbZ6wX3uP3gq7TSUm1EWF0u9GieU44lqjZaE5dt0maGwDOvXGp+XbP1zx6PHADzwU9qfqmLLnk2 XpQ/zrVLq+U2ZRoQzbJjdRQ9Q4/SbwgmBscka8JruCePNNX+1uZW7hMeUKa/9di4XQFtAAf9sKW q0pJ9aDlO/DZJWCE0iMdko6yj9XaxkZ5XGpuvUrmRSAqj1L67BKEdZrc5gLANpuPSEB40y4rA/y uDdYlAmii0GcuOknQrYa2WYfaYmwElEMAB2W6nhyzojIqrVOl7hs4U/tJG09wyB818oqs9cZsrM UfZlZmUY4UQa6VeFJcT+gKGgVUTz31XGxSIl6QfZTzKx8LXbbkMJ6x5hdDzVgIvGf+C+id0iy6 X-Received: by 2002:a05:6000:22c9:b0:43c:f1da:487d with SMTP id ffacd0b85a97d-43cf1da48c5mr16375164f8f.2.1774880508452; Mon, 30 Mar 2026 07:21:48 -0700 (PDT) Received: from timur-hyperion.localnet (5E1BC26F.dsl.pool.telekom.hu. [94.27.194.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf245ebafsm18062796f8f.21.2026.03.30.07.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 07:21:48 -0700 (PDT) From: Timur =?UTF-8?B?S3Jpc3TDs2Y=?= To: stable@vger.kernel.org, Rosen Penev , Christian =?UTF-8?B?S8O2bmln?= Cc: Alex Deucher , "Pan, Xinhui" , David Airlie , Daniel Vetter , Harry Wentland , Leo Li , Greg Kroah-Hartman , Bin Lan , He Zhe , Vitaly Prosyak , Alex Hung , Rodrigo Siqueira , Mario Limonciello , Ray Wu , Wayne Lin , Roman Li , Eric Yang , Tony Cheng , Mauro Rossi , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , open list Subject: Re: [PATCH for 6.12 3/9] drm/amd/display: Disable fastboot on DCE 6 too Date: Mon, 30 Mar 2026 16:21:46 +0200 Message-ID: <7351746.9J7NaK4W3v@timur-hyperion> In-Reply-To: <6b15401c-1fdf-4d3b-84aa-dfc47f430895@amd.com> References: <20260326234716.16723-1-rosenp@gmail.com> <2312151.9o76ZdvQCi@timur-hyperion> <6b15401c-1fdf-4d3b-84aa-dfc47f430895@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Monday, March 30, 2026 3:55:55=E2=80=AFPM Central European Summer Time C= hristian=20 K=C3=B6nig wrote: > On 3/30/26 15:16, Timur Krist=C3=B3f wrote: > > On Friday, March 27, 2026 12:47:10=E2=80=AFAM Central European Summer T= ime Rosen > > Penev>=20 > > wrote: > >> From: Timur Krist=C3=B3f > >>=20 > >> [ Upstream commit 7495962cbceb967e095233a5673ea71f3bcdee7e ] > >>=20 > >> It already didn't work on DCE 8, > >> so there is no reason to assume it would on DCE 6. > >>=20 > >> Signed-off-by: Timur Krist=C3=B3f > >> Reviewed-by: Rodrigo Siqueira > >> Reviewed-by: Alex Deucher > >> Reviewed-by: Alex Hung > >> Signed-off-by: Alex Deucher > >> Signed-off-by: Rosen Penev > >=20 > > This patch is incorrect and should not be backported. > >=20 > > (Note that the error is already fixed upstream. For stable kernels IMO > > it's > > best to drop this one.) >=20 > Is there some alternative which needs to be backported or should the old > kernel just work out of the box because we never enabled some feature > there? >=20 > Apart from that the patch set looks good to me. >=20 This patch had a typo and does the opposite of what it should, ie. it disab= les=20 eDP fastboot on DCE10 and newer instead of disabling it on DCE8 and older. The upstream fix is here: https://lists.freedesktop.org/archives/amd-gfx/2026-February/138577.html which disables eDP fastboot on DCE10 and older. >=20 > >> --- > >>=20 > >> drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 6 ++---- > >> 1 file changed, 2 insertions(+), 4 deletions(-) > >>=20 > >> diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c > >> b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c index > >> df69e0cebf78..7dc99c85b8ea 100644 > >> --- a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c > >> +++ b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c > >> @@ -1910,10 +1910,8 @@ void dce110_enable_accelerated_mode(struct dc *= dc, > >> struct dc_state *context) > >>=20 > >> get_edp_streams(context, edp_streams, &edp_stream_num); > >>=20 > >> - // Check fastboot support, disable on DCE8 because of blank > >=20 > > screens > >=20 > >> - if (edp_num && edp_stream_num && dc->ctx->dce_version !=3D > >=20 > > DCE_VERSION_8_0 > >=20 > >> && - dc->ctx->dce_version !=3D DCE_VERSION_8_1 && > >> - dc->ctx->dce_version !=3D DCE_VERSION_8_3) { > >> + /* Check fastboot support, disable on DCE 6-8 because of blank > >=20 > > screens */ > >=20 > >> + if (edp_num && edp_stream_num && dc->ctx->dce_version < > >=20 > > DCE_VERSION_10_0) > >=20 > >> { for (i =3D 0; i < edp_num; i++) { > >>=20 > >> edp_link =3D edp_links[i]; > >> if (edp_link !=3D edp_streams[0]->link)