public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian@openwrt.org>
To: Rogier Wolff <R.E.Wolff@bitwizard.nl>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: BCM36xx support.
Date: Thu, 31 May 2012 15:55:34 +0200	[thread overview]
Message-ID: <7383662.i0oNtC19fQ@flexo> (raw)
In-Reply-To: <20120418055139.GA25952@bitwizard.nl>

Hi Rogier,

First of all, you should have CC'd linux-mips, because that's where BCM63xx 
development happens.

On Wednesday 18 April 2012 07:51:40 Rogier Wolff wrote:
> 
> While working on SPI and I2C support for the BCM2835, I found the
> BCM63xx SPI driver in the kernel. Turns out that this support
> was partially merged: 
> 
> The support can only be enabled when BCM63xx configuration symbol
> is defined which menuconfig lists as: 
> 
>  Symbol: BCM63XX [=BCM63XX]                                                
>    Type  : unknown                                                           
> 
> I'd say the definition of this is not possible through the normal
> channels.
> 
> And in the driver (drivers/spi/spi-bcm63xx.c) I see: 
> 
> #include <bcm63xx_dev_spi.h>
> 
> but that file is not in the current git release.

No, it did not make it for a reason I ignore, probably miscommunication.

> 
> (some more googling has resulted in me finding out that I don't want
> to know how the 63xx SPI controller works as it's for a MIPS processor
> while the 2835 is ARM).

And so? if the core is the same, just use it on your platform too. If you have 
a look at the architecture files, you will see that the various BCM63xx SoC 
have their internal registers shuffled but the SPI core is always software 
compatible, another set of registers can be added for BCM2835.

I have no objection making such a driver more generic and not limited to 
bcm63xx like it is right now.
--
Florian

  reply	other threads:[~2012-05-31 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18  5:51 BCM36xx support Rogier Wolff
2012-05-31 13:55 ` Florian Fainelli [this message]
2012-05-31 14:25   ` Rogier Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7383662.i0oNtC19fQ@flexo \
    --to=florian@openwrt.org \
    --cc=R.E.Wolff@bitwizard.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox