From: Diederik de Haas <didi.debian@cknow.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
debian-kernel@lists.debian.org,
Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
ath10k@lists.infradead.org, Ben Hutchings <ben@decadent.org.uk>
Subject: Re: ath10k_pci logs errors about missing pre-cal and cal firmware on a laptop
Date: Tue, 14 Nov 2023 22:49:50 +0100 [thread overview]
Message-ID: <73921857.09T0xDi13r@bagend> (raw)
In-Reply-To: <58d017a1-cae6-46d8-9cee-515dbf607051@molgen.mpg.de>
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
FTR: I do NOT speak on behalf of the Debian kernel team.
On Tuesday, 14 November 2023 20:58:58 CET Paul Menzel wrote:
> > Based upon the message:
> > [ 14.401143] firmware_class: See https://wiki.debian.org/Firmware
> > for information about missing firmware
> >
> > it seems you are not running a stock kernel. So perhaps Debian has
> > modified the firmware loading such that it ignores the FW_OPT_NO_WARN
> > flag and warns even when told not to do so? This does not appear to be
> > an upstream kernel issue.
>
> Thank you very much for the analysis. It seems to be indeed a Debian
> specific patch [1].
>
> Dear Debian Linux kernel team, is my observation about the error log a
> result of the patch and intended?
>
> [1]:
> debian/patches/debian/firmware_class-refer-to-debian-wiki-firmware-page.patch
There are a number of Debian patches wrt firmware and *I* think they should get
a (serious) review. In https://bugs.debian.org/1040738 I requested a review of
the firmware related patches and described one of the issues I encountered
myself. I've also been involved in triaging Debian kernel bug issues and there
I've encountered several more such cases.
AFAIK quite a bit of work has happened upstream to make the firmware messages
more appropriate and I think the Debian patches haven't been (properly)
adjusted for those changes.
So they are (very) likely caused by the Debian patches and thus expected, but
I'm hesitant to call them intended ;-)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-11-14 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 12:13 ath10k_pci logs errors about missing pre-cal and cal firmware on a laptop Paul Menzel
2023-11-14 17:32 ` Jeff Johnson
2023-11-14 18:19 ` Jeff Johnson
2023-11-14 19:58 ` Paul Menzel
2023-11-14 21:49 ` Diederik de Haas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73921857.09T0xDi13r@bagend \
--to=didi.debian@cknow.org \
--cc=ath10k@lists.infradead.org \
--cc=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox