From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 857653BC68A for ; Tue, 19 May 2026 07:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779174717; cv=none; b=nw3nHY4dTyFz2zRXkgHLwAV3+JKaRr6A4UlZpkf/W+AuXMV25yc6k0QwbCWMy82KSFtZzHmz6NJCYdLKdZ+qbiY4Pje4i470Zg79C7+qSnbxRoxMt5zUDBbfRJUwOMaBWY9n2t1fP8oNSc5SrpskJfcPdMX2Mx1ePaJYdoIdabU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779174717; c=relaxed/simple; bh=wztDeudGoUAJK/W//ID8zMxaTkHI3uWCRMPOPLm6LPk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dDE1aPvV/Uoxws4I8dU5qLJ7/kXgOUl/xAMZxES4lRXDmJ9L+J7GLciP1VE+de9PIDtpwnlpr3KRGp3utn4eNs8IM4if/xvHqKZ3CwpOjFIkY3BmqGAeXy8X4UoJSkeYEFIYMX/orC9kL0O2OQaOBtcoBgN0y3GLIzoHTTaksjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mjUlCDP8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mjUlCDP8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso32558345e9.1 for ; Tue, 19 May 2026 00:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779174712; x=1779779512; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xjjvfitJbUO5+jLc8/tMROrf3YtISQkTQKy+IqYQDo8=; b=mjUlCDP8YywlfT2Esou3YpzxuaFoN5/JbU+g+6VrJp+vUJV4lNc4SSvZBElyAQQPVA +sAp+/Ad5PTx9ciAtr/H0L5pne24TINvTB6ZoQAkQtHm5yD9bsrJroWRxg4Y1fgIMOKC nRZQqc8VifCzIWfFs2ztXStM4SriFAFWXf7TrXJiA5GMq0v9mDiUY+aZHckT0NuK6xbo TVZObx2uCcg1c6MajmAsVmmmONfHtWtGOskWf/5o6hsMPFO7SARiCBhqKM6GxpSZ0l+B vddLXOPMLVCDVqkzar2xXwehUOzvUXHBGGmKUTFsyJmF8a8iSsbFumCf4qtBwMNHq5rM g+cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779174712; x=1779779512; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xjjvfitJbUO5+jLc8/tMROrf3YtISQkTQKy+IqYQDo8=; b=MocgJWNSqgv8rSys9xp47sIHaYG0gi2UbFWUiFl0HEEzwZYHu0d00pXop3HiKMCI4m 068oPuY+6IJuiEU5mLpSrPV7cbzTAF9LV2fmFAbe9YkFiDnfKQzeMwvAfVIAEyN8Augz ETFY9gzVXUwVmM5/yDv0NNsKhiKeIp1i9QP67+95fGlLKCnFdAIgaElLLHvhGGXAN59T iR5rMqMnxZPp3bYlp5Z8ZnqPGBatWiYHpo25Z9PaDKVVt88FeerzTgpgJIzRrej9BRQM a+0WxP4B7sY26KPMSphr6kjqYPoCDLbTZVxMbTqkk1DRkd1xgm3k3bkJiEOaeBDPhFlv FbOw== X-Forwarded-Encrypted: i=1; AFNElJ+lslZLw9fWRvUIKnppQiNVsBXdFvtCf2yyvGsUIoywHd6VpjV+6R08U/5Y16erZKkBqQHdC9sX7efI2WI=@vger.kernel.org X-Gm-Message-State: AOJu0YxOSUJN59Zz1jMSrGn+/VvTxDkqa0PvpV7bQuNPpPa+lWFYIPA6 2o0nbtT2hwPXb0qOfOUcWJPNjg/3dWE66MJzrphel8kn/ae3cHwacCy5 X-Gm-Gg: Acq92OGNZMTVNms/rOzAoGmaOuXSfwqCGYmpJ+v3734cDmzb/ABEFbWN3p9nwKFujLJ UXDm4x10Ijhm9Pntv6MsW/LKQyvnw+5bRkKWQ6jTdiqOz9lbBEUcRkxLkLkOK9uS+39gFvYs3A1 Y65iHnGoQBKHwGZ8UY1wQbFs15NFmqyGShCQiOFR0J82iLnAa0EgCSmpLhJBEQxGvVLSj86wIj9 +4HiQWO1fIce7F2i8V9yU8nTlB3FtENB5XzKQE5yeW22C6Wd5YvZA+jAZuyc6Aqivuz54mrZkvu tiL0dEWfEVOQoYV0h0HRcEzfq+EPicHEhykyhKzHabgK1rPgcmyX/YBJFh7vmtywtoupi00IWd4 R9xJnHtl8LG/F2x5IA0u2t8E3/jwd2dhYaKcyR+6ZS4B6MAcKN+7OM2kiX2Zkp07bgE19lQyuij i3L1sr6hnl5/szRiMB5NJO/C1/xsU9jWiE5hdoyN6vMJFaaxD5y9A1ygSARjmLfF6tVehH X-Received: by 2002:a05:600c:a09:b0:485:3cef:d6ea with SMTP id 5b1f17b1804b1-48fe539198fmr259597035e9.13.1779174712366; Tue, 19 May 2026 00:11:52 -0700 (PDT) Received: from ?IPV6:2a02:3033:6d8:15d8:ec15:f5ad:b85f:a3b8? ([2a02:3033:6d8:15d8:ec15:f5ad:b85f:a3b8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe53ab671sm309396375e9.1.2026.05.19.00.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:11:52 -0700 (PDT) Message-ID: <739f50f4-b2f5-4e5f-8d1b-d5a6429ece28@gmail.com> Date: Tue, 19 May 2026 09:11:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] iio: dac: Add AD5529R DAC driver support To: David Lechner , Janani Sunil , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20260508-ad5529r-driver-v2-0-e315441685d7@analog.com> <20260508-ad5529r-driver-v2-2-e315441685d7@analog.com> <2f74e76e-b066-40ac-9cb4-c75137c9825d@baylibre.com> Content-Language: en-US From: Janani Sunil In-Reply-To: <2f74e76e-b066-40ac-9cb4-c75137c9825d@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/16/26 21:35, David Lechner wrote: > On 5/8/26 6:55 AM, Janani Sunil wrote: >> Add support for AD5529R 16-channel, 12/16 bit Digital to Analog Converter >> > ... > > >> + .realbits = (bits), \ >> + .storagebits = 16, \ >> + }, \ >> +} >> +static struct regmap *ad5529r_get_regmap(struct ad5529r_state *st, unsigned int reg) >> +{ >> + if (reg <= AD5529R_8BIT_REG_MAX) >> + return st->regmap_8bit; >> + >> + return st->regmap_16bit; >> +} > Another way we have done this is make custom read/write functions for the > regmap itself so that we don't have to have two regmaps. Dual regmap approach was chosen here because: 1) It leverages regmap's val_bits validation and endianness for 16 bit registers, rather than implementing them manually. 2) The two distinct register banks- 8 bit and 16 bit map naturally to the separate regmap configs 3) Each regmap has a focused rd_table/wr_table ranges matching the hardware, rather than a complex unified table The routing overhead is just an address comparison, similar to what custom functions would need, but with automatic validation and endianness handling Best Regards, Janani Sunil