From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: "Alexander F. Lent" <lx@xanderlent.com>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>,
Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] accel/ivpu: Add missing MODULE_FIRMWARE metadata
Date: Tue, 9 Jul 2024 12:10:02 +0200 [thread overview]
Message-ID: <73a245d2-2e12-476a-b22a-cc11bdcecef0@linux.intel.com> (raw)
In-Reply-To: <20240708-fix-ivpu-firmware-metadata-v2-1-78b953172026@xanderlent.com>
Hi,
Just two more comments and we are good to go.
On 09.07.2024 02:25, Alexander F. Lent wrote:
> +/* Add module metadata for the production firmware paths.
> + * This needs to be kept in sync with fw_names above.
> + */
I would prefer:
/* Production fw_names from the table above */
> +MODULE_FIRMWARE("intel/vpu/vpu_37xx_v0.0.bin");
> +MODULE_FIRMWARE("intel/vpu/vpu_37xx_v0.0.bin");
You probably meant *40xx*.
Regards,
Jacek
prev parent reply other threads:[~2024-07-09 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 0:25 [PATCH v2] accel/ivpu: Add missing MODULE_FIRMWARE metadata Alexander F. Lent
2024-07-09 10:10 ` Jacek Lawrynowicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a245d2-2e12-476a-b22a-cc11bdcecef0@linux.intel.com \
--to=jacek.lawrynowicz@linux.intel.com \
--cc=andrzej.kacprowski@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=krystian.pradzynski@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lx@xanderlent.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox