public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>, corbet@lwn.net
Cc: akpm@linux-foundation.org, broonie@kernel.org,
	weizhenliang@huawei.com, georgi.djakov@linaro.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	hanshenghong2019@email.szu.edu.cn,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] Documentation/vm/page_owner.rst: fix the description of "-f"
Date: Fri, 25 Feb 2022 14:45:13 -0700	[thread overview]
Message-ID: <73c74276-3c29-e662-cb96-c09fbba0d2b1@linuxfoundation.org> (raw)
In-Reply-To: <20220225090824.2343-1-caoyixuan2019@email.szu.edu.cn>

On 2/25/22 2:08 AM, Yixuan Cao wrote:
> Few days ago,
> I noticed that in tools/vm/page_owner_sort.c,
> there is a comment that need to be fixed.
> 
> In function usage():
> "-f Filter out the information of blocks whose memory has
> not been released."
> 
> This comment does not match the actual function, the "not"
> should be removed. As a result, I submitted a patch to fix it.
> 
> Similarly, this document should also do the same
> modification, that's why I submit this patch.
> 

Please refer to a few change logs to write them so maintainers
don't have to fix them. This can be written as:

"Fix function usage information for -f option"

> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
> ---
>   Documentation/vm/page_owner.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index aec1906976f4..32ca54757d3f 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -78,7 +78,7 @@ Usage
>   
>   2) Enable page owner: add "page_owner=on" to boot cmdline.
>   
> -3) Do the job what you want to debug
> +3) Do the job what you want to debug.
>   
>   4) Analyze information from page owner::
>   
> @@ -126,4 +126,4 @@ Usage
>   		-c		Cull by comparing stacktrace instead of total block.
>   
>   	Filter:
> -		-f		Filter out the information of blocks whose memory has not been released.
> +		-f		Filter out the information of blocks whose memory has been released.
> 

I can't find this in Linux 5.17-rc5 - is this patch based on linux-next?

thanks,
-- Shuah

      reply	other threads:[~2022-02-25 21:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25  9:08 [PATCH] Documentation/vm/page_owner.rst: fix the description of "-f" Yixuan Cao
2022-02-25 21:45 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73c74276-3c29-e662-cb96-c09fbba0d2b1@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=caoyixuan2019@email.szu.edu.cn \
    --cc=corbet@lwn.net \
    --cc=georgi.djakov@linaro.org \
    --cc=hanshenghong2019@email.szu.edu.cn \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weizhenliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox