public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Dragos Bogdan" <dragos.bogdan@analog.com>,
	"Anshul Dalal" <anshulusr@gmail.com>,
	"Andrea Collamati" <andrea.collamati@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
Date: Wed, 29 May 2024 10:09:28 +0200	[thread overview]
Message-ID: <73d7ba0e54a93696aa2c8cab3e6599038bddf533.camel@gmail.com> (raw)
In-Reply-To: <81ec1d1a-d8de-47e4-a5d4-eeaaf1e806a2@app.fastmail.com>

On Wed, 2024-05-29 at 09:23 +0200, Arnd Bergmann wrote:
> On Wed, May 29, 2024, at 09:20, Nuno Sá wrote:
> > On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > > 
> > > Build testing without SPI results in a warning:
> > > 
> > > WARNING: unmet direct dependencies detected for REGMAP_SPI
> > >   Depends on [n]: SPI [=n]
> > >   Selected by [m]:
> > >   - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
> > > 
> > > There is no need for this particular COMPILE_TEST option, as allmodconfig
> > > and randconfig testing can just assume that SPI is enabled separately.
> > > 
> > > Drop it to avoid the warning.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > 
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > 
> > Only for my understanding. When does COMPILE_TEST makes sense to add?
> 
> The most common use is to enable building a driver
> that is platform specific on x86 allmodconfig
> or on randconfig, e.g.
> 
> config LPC18XX_DAC
>         tristate "NXP LPC18xx DAC driver"
>         depends on ARCH_LPC18XX || COMPILE_TEST
>         depends on HAS_IOMEM
> 
> Since ARCH_LPC18XX is only visible on arch/arm, the
> driver would never be build tested on anything else
> without the ||COMPILE_TEST.

Makes sense... Thanks!

- Nuno Sá


  reply	other threads:[~2024-05-29  8:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 12:12 [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option Arnd Bergmann
2024-05-29  7:20 ` Nuno Sá
2024-05-29  7:23   ` Arnd Bergmann
2024-05-29  8:09     ` Nuno Sá [this message]
2024-06-02 12:14       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73d7ba0e54a93696aa2c8cab3e6599038bddf533.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=andrea.collamati@gmail.com \
    --cc=anshulusr@gmail.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=dragos.bogdan@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox