From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92C140D59F for ; Thu, 11 Jun 2026 11:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781175934; cv=none; b=WAf3w0FLeBgYRyrN3iycquoYqfuIg6t9RZsQdpzud/pwSHb5TdePps3T2AyGiefTN4IdFX/O2dyRZzZno+Ol0edSs4W43ac8JEKLWsz8NrX05BZHaUyEtZA7tzZhxxz6vo/aJXpF9WFR5TFgghfjkMbR5yFyY0kFZW8DaueoAPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781175934; c=relaxed/simple; bh=/wxQSaRakumNKYB4vqjOTBgyQzqMLc8DAYpMLHYYAXA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NwJoCYEoiyN9cP7FmZko5b+bsbfd80IWHNLZamGJ/b3rXCVeck3Beqd8L+Pf7c9sN52LiQWqzKiC8uHbNjOcNZoOt/r6Zb7Yq/ZKD+diR5oYK2dl9mM7jqdE3/52ypPVMTbzRJiDOtKEJ9qpeH7SwBtEz5qUU8l5VU64eEsfcRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I2xWBKdv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FFavymKI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I2xWBKdv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FFavymKI" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B9xB4M263539 for ; Thu, 11 Jun 2026 11:05:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MaD+SVyMDIg2d/edNc/15/ePklSjOmExxWuDVzVekf4=; b=I2xWBKdvhWa3HVSh QJ+IsVIexhJqMUy6ElBfAfFWdp5vQS6zDAdb3s4+Ud8avq+JzY8O82W9FJRW540n wZoMLSObdhjjI70P2oXAaSOzmoMiXI1PcIodMEIWmbRRGv/V9fmPGtKGEzj7/SgH lfAO37K6fhVHofZ02qqIjv51qiaCx0Ex9rO95EFp87SYQDR1Zzr3sMl9JZYM5WdP 5bvYjISYlxNGSnvggUKGLw4PPNgLNyFknKDLP9NiAPWMdCDDeGteGa05jUx0p9bl OE0itsiGObG3+PJlmSsZeTRgYRRFQnEmY2CPM3dlNFY3UdtY+/bOW98xzpv4gM/Z DNY4zg== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6uu2dk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 11:05:32 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ccdd99d20dso21791566d6.2 for ; Thu, 11 Jun 2026 04:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781175931; x=1781780731; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MaD+SVyMDIg2d/edNc/15/ePklSjOmExxWuDVzVekf4=; b=FFavymKIHYJJwHUugIKrhSGRBc3MhFprYBZw6k2R3A+Ie1UtCG1nNgHJttQqmWKKPb EaBLaQsD8HOieM1VsI7XoJx3qn9F6zk7wzr5wZSWZsl4yIgM1T+1oNiPJDYY7McLmzOB MJrK3vmdeYRM+jmcRw1mKdphVEqyfNBWj6NF/brR4nnItcmc1Jml7d95x+x11GydSS3w 8GZAX5QS/OFXpej36PfiUb1RkPCB22+zwizBnkr8KUMb0mgzBB96RhQitxkiWyRVXkN0 I5tvVdLXRA0gW4QRpVdWsnP1QgmLO/tyQmzVGW1NWQ1H1ZI+bZY6JENvFkKa2oHbgUqq S4fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781175931; x=1781780731; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MaD+SVyMDIg2d/edNc/15/ePklSjOmExxWuDVzVekf4=; b=OBSQ3NPy3rVQGJNjo1S5cPOKqI+PbxMRpEUuQ96vV9PNyfEHvTnU7yNx7b+oiLEa+I TxRymKLBXpznN/KM/tWchE9OgavuDm5eIogjzkEo+oTnRLdFVmmJ+rTWFG+DqRrjc5BC Rg3B3v57IacQHR+3Q1TPbIGuiJ7BV8hrd9DDdsutGyBaf5E0PqLEc8Qyvnh9MvL4UHpU Hf/EIdp1HmfVWUzxlenafC4rnm8VkoqpiqVvZYDwfTZhZLKnNrwrzMb3D6UHwa4sJk30 ljbQph7/UCpZfZfrLrR0F541cDHO8te/SLrr8UnkdgePj868UwyaMIqDqqhTnaUEu4wf U6JQ== X-Forwarded-Encrypted: i=1; AFNElJ99HiFtaFzj/qNhUEQ8Lxtzj3mWcJEUVNSpSZA45zknX8+I6gDQGkT0uHyqCbdZzwsE3Syr0VxALBu4xz8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5SSJu/Fe1F1f1bs+0MEwQsu3UZalsgzOE4yBLTTGTNevQM/5+ eExFfv+4qrTfWslWRlGA1SLQ5AyBOfqyHQmfgGnMzvmjvFkEuNcw98TEkdwotLqxEA7w2wFVM1w tDZPbCIseIWiSth05yqHKz0Y6qiLjL/6xWyXv4WGZrkUSUOYBA8TCyZYz7zAWICqahD8= X-Gm-Gg: Acq92OGAzvsYAJpi4Yg7E6deLqTbczK3Lx+NbzzEHC5k6kZOHEjdtQgOGOuJxGQbT/y qPk3r00IECtxjoQe2Oh3eaLjjzI2KXhAzCsEMru9OY5swNdvMl6G0Uw4XAX92G/sFiJSUXclVrj vvwuJ0Q0B1xKM4VlCZqEyerOqF/v/iTqc1ogImdSKB4FfJoZVmUl7V2aH0X88iGOze615uM3oaX gPEJ0p+1XCGRqV4Z4egsb5IaKbu9wxVh6h5B1vGUawLoRV+aZFvlXj+1lywpFY3QGkQRjej0x27 mIjlQ8/2c494sQ1DwZk+ei2lHiIBTcx7NmCiESN+82/EpKy20L9LEwnQ/lcEyImBlhJEX8DX/Uq oR6nx1m/jsemlQsfKWKHc8mFgYnp5LTMq1JKkd3kcU6OHsN9LgiHRauEn X-Received: by 2002:a05:620a:1713:b0:902:daaf:22cd with SMTP id af79cd13be357-9160a4f660cmr192689885a.0.1781175931062; Thu, 11 Jun 2026 04:05:31 -0700 (PDT) X-Received: by 2002:a05:620a:1713:b0:902:daaf:22cd with SMTP id af79cd13be357-9160a4f660cmr192684285a.0.1781175930499; Thu, 11 Jun 2026 04:05:30 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e65867e7dsm10880036a12.20.2026.06.11.04.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 04:05:29 -0700 (PDT) Message-ID: <73f700f2-7cba-4832-bd06-e82a7fd51a7a@oss.qualcomm.com> Date: Thu, 11 Jun 2026 13:05:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] irqchip/qcom-pdc: Configure PDC to pass through mode To: Maulik Shah , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260526-hamoa_pdc-v2-0-f6857af1ce91@oss.qualcomm.com> <20260526-hamoa_pdc-v2-5-f6857af1ce91@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260526-hamoa_pdc-v2-5-f6857af1ce91@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=FJ8rAeos c=1 sm=1 tr=0 ts=6a2a967c cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=avOr_zNKPfybmo9zg3EA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDExMSBTYWx0ZWRfX2cnYuhcfdmGe l7kZlSknc7nFIrmcqibDAfDVVvlU6/PiMLxjVQZtpfGmT8HQuq6l/ZcU0EkBZeMvjJEl+enPjr+ 77dXSkmZy97i/3yfkOaZOZ+dwhqyPGI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDExMSBTYWx0ZWRfX+B7wb6l0xoOL nn8UnOzDY1wyhIbX9qn0OnrJB1DmoSBXBcNbi+7RVHWpYyX5Oygo+TQNzBQn4BcQ07D/2l/lW5u m4eq/ZWuOqxApvJlrs8LBasOuvIUaEj6wM8lGG3UhIcUMTCfwH9xPkKZz93+3xnFCHmkAdValsL 7pj6j6tLGiW15lagZTk769vHuZpjNfeEPhdd12FwOtGZNs/vCDO3uK8LtA47UZEQFVsHmb/izeF XjVoFoUslwke29gOfzfCvrBzM1ModzVCSANVx5AMZHsToJJ3bKjxIQqduyIi6ilh0d8Pcv5nrWH C5Z2hvb2aPAzgMpneoMQTxfJYL2minlbRCObfxPvWCBg7cm/qiXkWdE1LqPihXk9a2yrC3m4Jst 44KEkj6YaSUIq6GDIHN8PVi89pPYuEpMzkvywOK5LlikjtSTfU7zk9IxEN8E/rmoTqIPJ2o0Qme WFAtAa//vGZQF0MSMpQ== X-Proofpoint-GUID: pHFfeC_nLu6yVLsrX0uvJmKeVWUdBWWS X-Proofpoint-ORIG-GUID: pHFfeC_nLu6yVLsrX0uvJmKeVWUdBWWS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110111 On 5/26/26 12:54 PM, Maulik Shah wrote: > All PDC irqchip supports pass through mode in which both Direct SPIs and > GPIO IRQs (as SPIs) are sent to GIC without latching at PDC. > > Newer PDCs (v3.0 onwards) also support additional secondary controller mode > where PDC latches GPIO IRQs and sends to GIC as level type IRQ. Direct SPIs > still works same as pass through mode without latching at PDC even in > secondary controller mode. > > All the SoCs so far default uses pass through mode with the exception of > x1e. x1e PDC may be set to secondary controller mode for builds on CRD > boards whereas it may be set to pass through mode for IoT-EVK boards. > The mode configuration is done in firmware and initially shipped windows > firmware did not have SCM interface to read or modify the PDC mode. > Later only write access is opened up for non secure world. > > Using the write access available add changes to modify the PDC mode to > pass through mode via SCM write. When the write fails (on older firmware) > assume to work in secondary mode. > > Co-developed-by: Sneh Mankad > Signed-off-by: Sneh Mankad > Signed-off-by: Maulik Shah > --- [...] > +static inline bool pdc_pin_uses_seconary_mode(int pin_out) Please add a comment somewhere near here, repeating what you said in the previous commit message (about the SPIs being mapped first, followed by GPIO-as-SPIs) Konrad