What happened to XFS Quota Support?

What happened to XFS Quota Support?

[AndyLiebman]

In previous Linux kernels -- 2.6.13 and below --  XFS quota could be set 
"statically" -- that is, in "make xconfig" you could put  a "check mark" in the 
XFS_quota support box even though you had a "dot" (module)  in the Overall 
XFS_Filesystem support box . 

In 2.6.14, not only has XFS  support moved under filesystems with all the 
other filesystems, but you can no  longer put a "checkmark" in the "quota 
support" box if you compile XFS support  as a module. 

Is this by design? Looking back at all of my past kernels,  xfs is enabled as 
a module but quota support is enabled statically. This is how  config files 
have been coming from Mandrake for at least the past year.  

Is there a reason why this option is no longer available? If you compile  
xfs_quota as a module, how do you load it? 

Andy  

Re: What happened to XFS Quota Support?

[Nathan Scott]

Hi Andy,

On Fri, Oct 28, 2005 at 03:04:10PM -0400, AndyLiebman@aol.com wrote:
> ...
> Is there a reason why this option is no longer available? If you compile  
> xfs_quota as a module, how do you load it? 

Oh, bother - the option:

config XFS_QUOTA
        tristate "XFS Quota support"

should be:

config XFS_QUOTA
	bool "XFS Quota support"

I'll get that fixed up, thanks.

-- 
Nathan

Re: What happened to XFS Quota Support?

[Alistair John Strachan]

On Friday 28 October 2005 20:46, Nathan Scott wrote:
> Hi Andy,
>
> On Fri, Oct 28, 2005 at 03:04:10PM -0400, AndyLiebman@aol.com wrote:
> > ...
> > Is there a reason why this option is no longer available? If you compile
> > xfs_quota as a module, how do you load it?
>
> Oh, bother - the option:
>
> config XFS_QUOTA
>         tristate "XFS Quota support"
>
> should be:
>
> config XFS_QUOTA
> 	bool "XFS Quota support"
>
> I'll get that fixed up, thanks.

This might be a good thing to put in 2.6.14.1.

-- 
Cheers,
Alistair.

'No sense being pessimistic, it probably wouldn't work anyway.'
Third year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

Re: What happened to XFS Quota Support?

[Nathan Scott]

On Fri, Oct 28, 2005 at 04:33:21PM -0400, AndyLiebman@aol.com wrote:
> I tried compiling XFS statically into the kernel and it's also a "no go" on  
> quota support. So, am I to conclude that 2.6.14 as it currently stands cannot  
> support XFS quotas?

Hmm, I'd have thought it'd work builtin, thats how I tend to use it.
Either way, the code is all there, its just an annoying config issue.

> As you know, we have quite a few users who have been waiting for the XFS  
> changes that went into 2.6.14 (as you and I have discussed).  Hope the fix  comes 
> along soon. 

Theres a patch already floating around that will resolve it, let me
know how that goes.

cheers.

-- 
Nathan

Re: What happened to XFS Quota Support?

[Nathan Scott]

On Fri, Oct 28, 2005 at 06:15:22PM -0400, AndyLiebman@aol.com wrote:
> could you be a little clearer on this. What do you mean by "there's a patch  
> already floating around". If I knew where to get the patch, I would have  
> installed it already rather than wasting half a day compiling various flavors of  
> the new kernel (no preemption, voluntary preemption, high preemption). 
>  

Oh, sorry - I was refering to this...

cheers.

-- 
Nathan

----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----

Date: Fri, 28 Oct 2005 22:33:25 +0200
To: Andrew Morton <akpm@osdl.org>, stable@kernel.org
Cc: linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, nathans@sgi.com,
   linux-xfs@oss.sgi.com, Dimitri Puzin <tristan-777@ddkom-online.de>
User-Agent: Mutt/1.5.11
From: Adrian Bunk <bunk@stusta.de>
Subject: [2.6 patch] fix XFS_QUOTA for modular XFS

This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 
fixes the following issue:

Cannot build XFS filesystem support as module with quota support. It 
works only when the XFS filesystem support is compiled into the kernel. 
Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

How to reproduce: configure the XFS filesystem with quota support as 
module. The resulting kernel won't have quota support compiled into 
xfs.ko.

Fix: Changing the fs/xfs/Kconfig file from tristate to bool lets you 
configure the quota support to be compiled into the XFS module. The 
Makefile-linux-2.6 checks only for CONFIG_XFS_QUOTA=y.


From: Dimitri Puzin <tristan-777@ddkom-online.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.14-rc5-mm1/fs/xfs/Kconfig.old	2005-10-28 19:51:02.000000000 +0200
+++ linux-2.6.14-rc5-mm1/fs/xfs/Kconfig	2005-10-28 19:51:12.000000000 +0200
@@ -24,7 +24,7 @@
 	default y
 
 config XFS_QUOTA
-	tristate "XFS Quota support"
+	bool "XFS Quota support"
 	depends on XFS_FS
 	help
 	  If you say Y here, you will be able to set limits for disk usage on


----- End forwarded message -----

Re: What happened to XFS Quota Support?

[AndyLiebman]

>In a message dated 10/28/2005 6:47:02 P.M. Eastern Standard Time,  
nathans@sgi.com >writes:
>This patch by Dimitri Puzin submitted through  kernel Bugzilla #5514 
>fixes the following issue:
>
>Cannot  build XFS filesystem support as module with quota support. It 
>works only  when the XFS filesystem support is compiled into the kernel. 
>Menuconfig  prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.
>
>Fix: Changing the fs/xfs/Kconfig file from tristate to bool lets you  
>configure the quota support to be compiled into the XFS module. The  
>Makefile-linux-2.6 checks only for CONFIG_XFS_QUOTA=y.
 
Just wanted to let you know this works fine. 
 
Andy Liebman