From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754665AbcARKmo (ORCPT ); Mon, 18 Jan 2016 05:42:44 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:60456 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562AbcARKmj (ORCPT ); Mon, 18 Jan 2016 05:42:39 -0500 From: Arnd Bergmann To: Russell King - ARM Linux Cc: Florian Fainelli , arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Date: Mon, 18 Jan 2016 11:42:05 +0100 Message-ID: <7401195.yJZcvlhzfd@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160118095919.GE19062@n2100.arm.linux.org.uk> References: <5641204.G6RtGs3Kji@wuerfel> <20160118095919.GE19062@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:QvtUxhOolLgvaHWrl5UK9Y/Pt6JBINArQxyKD4VJTYQTHOg5wG7 4dilbZ6ZoUriZ8txVI32+dyTVKfXY53NjikmJnVoF3mYiXlFoDZTYAXPfHuJFZJgqCC1Ltc JanapCyH55rKTRieYw6RMkUMwNAkulYEB026VRPTWAVUEJoX0XIpA7S/ETq22SBSE+p1Lg0 F6ifUkj0jrT5cOH5bxsJw== X-UI-Out-Filterresults: notjunk:1;V01:K0:LFGh65g82hE=:Xa3o2olFS88U+Y0JsiVEQr 03SnL56R3rSTieAebAt64JCI7qHM8LtSFuKYUj8hgHP0ZTqa3LgGaUorHvUVNmz4OBeYZeDn9 YRc2fmdqTzNLLZdYCuoFnfZFtBJbD+gAF6oE7Rr982kXw8cbG86LwVR0wcYisAMhRaLh3mkJQ 02s0dCSQKw1+Qsh0WvInyLjh2UagRgBncY9GtoZwDxBaLjexrRSs07HL/Bb8CRsKXqKmIsyX2 yyijnYvKonUkEGcH03XWT75/J14OTKe8Fd0AJ+t39E+huaXdvHLK06wPihHRM8xVozdqVlfL1 /aVk6Uq25dukHFQ41C1RmgdMMCxUqJV4/HJj/ppQf1+T2ZFoaxjHGpcqZUUnkS+ypMYpHonAH BSYBphQQP8P9e3zTY9D5kEYCjcKcX2dIgIY60sECjzCjggIStnVE7mSLALt7o0vu+mwXJZ5Bp 2AN7eZn1+6CJNsuxP9VLftOH0ukaaQvYNZAdMg2ELFnUKDpX+QBWrRg0uCvcLi8894t3Sct8l wDz9f6eeFXrYE+DvpvEJlpBIDJFYJiBbwXnpuA/r+nGhXD3muC6yeyRk2xPDa0I6+5Q7o/+oO Wc56nDfR0e5M23dnwMI/4JjOL/CEh/VXwZcmKn8aJtiIt6bBxogwjgJyXQxWwxWFNTSkAWE2y 2Wh4Pc6fBxIsvusJuCMASJZHUofRHPSGwDRPa+ILKVrQcrY+VfASayxBKypNZA6ttKchp2amd v7cuFEAguZhOcD6u Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 18 January 2016 09:59:19 Russell King - ARM Linux wrote: > On Mon, Jan 18, 2016 at 10:51:00AM +0100, Arnd Bergmann wrote: > > During my randconfig build testing, I found that a kernel with > > DEBUG_AT91_UART and ARCH_BCM_63XX fails to build: > > > > arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror] > > Why do we have files defining CONFIG_* symbols? This is the real error > here - no source file should be defining this. I agree that we should change that too, I'll send a patch for it as well. However, this just let me stumble on the problem, without AT91 getting this wrong, I would not have noticed that bcm63xx breaks other platforms. The AT91 thing is just confusing but otherwise harmless, and I wouldn't mark that fix for stable. Arnd