Re: [PATCH] Version2 Smack: Simplified Mandatory Access Control Kernel

Jan Engelhardt
2007-08-30T19:01:15Z

On Aug 27 2007 23:59, Thomas Bleher wrote:

>> + for (cp = data - 1; cp != NULL; cp = strchr(cp + 1, '\n')) {
>> + if (*++cp == '\0')
>> + break;
>> + if (sscanf(cp, "%14s %30s\n", name, target) != 2) {
>> + printk("%s:%d bad scan\n",
>> + __func__, __LINE__);
>
>Leftover debugging printk? Otherwise, a level would be nice.

Or even pr_debug.

(pr_debug("%s...

>> + static struct tree_descr smack_files[] = {

Hey, can we make this const, if it does not change at runtime?

Jan
--