From: kgunda@codeaurora.org
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Fenglin Wu <fenglinw@codeaurora.org>,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0
Date: Thu, 06 Jul 2017 15:51:57 +0530 [thread overview]
Message-ID: <740ccb0a99eb927fb02965018b7d1619@codeaurora.org> (raw)
In-Reply-To: <20170706065358.GF22780@codeaurora.org>
On 2017-07-06 12:23, Stephen Boyd wrote:
> On 07/03, Kiran Gunda wrote:
>> From: Fenglin Wu <fenglinw@codeaurora.org>
>>
>> The opc parameter in pmic_arb_write_cmd() function is defined with
>> type
>> u8 and it's always greater than or equal to 0. Checking that it's not
>> less than 0 is redundant and it can cause a forbidden warning during
>> compilation. Remove the check.
>>
>> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
>> ---
>
> You forgot your sign-off here.
yeah.. forgot. Will add it.
prev parent reply other threads:[~2017-07-06 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 12:52 [PATCH V1 0/4]: spmi: pmic-arb: support for V5 HW and bug fixes Kiran Gunda
2017-07-03 12:52 ` [PATCH V1 1/4] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda
2017-07-06 6:51 ` Stephen Boyd
2017-07-03 12:52 ` [PATCH V1 2/4] spmi: pmic-arb: fix a possible null pointer dereference Kiran Gunda
2017-07-06 6:52 ` Stephen Boyd
2017-07-03 12:52 ` [PATCH V1 3/4] spmi: pmic-arb: add support for HW version 5 Kiran Gunda
2017-07-06 6:59 ` Stephen Boyd
2017-07-06 10:48 ` kgunda
2017-07-03 12:52 ` [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda
2017-07-06 6:53 ` Stephen Boyd
2017-07-06 6:53 ` Stephen Boyd
2017-07-06 10:21 ` kgunda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=740ccb0a99eb927fb02965018b7d1619@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=fenglinw@codeaurora.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox