From: Kirill Tkhai <tkhai@yandex.ru>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 0/1] wait queue head; locking considerations
Date: Fri, 06 Dec 2013 20:34:04 +0400 [thread overview]
Message-ID: <7411386347644@web22m.yandex.ru> (raw)
In-Reply-To: <1386343162-53574-1-git-send-email-paul.gortmaker@windriver.com>
Hi,
06.12.2013, 19:24, "Paul Gortmaker" <paul.gortmaker@windriver.com>:
> Peter pointed out[1] that the simple wait queues in RT could
> run any number of wakeups with the wait queue head lock held.
>
> It turns out that this isnt really specific to RT, but it is
> mainline too -- all the __wake_up_XYZ that in turn use the
> __wake_up_common boiler plate end up looping over all the
> callbacks (normally ttwu) while holding the head lock.
<snip>
One more problem with wait queues in RT case.
Wait queues moving from spinlocks to rt_mutexes makes timerfd
not irqsafe on RT. This makes it unusable for some user tasks.
> fs/timerfd.c | 26 ++++++-------
> include/linux/wait.h | 36 +++++++++++++++---
> kernel/sched/completion.c | 24 ++++++------
> kernel/sched/core.c | 8 ++--
> kernel/sched/wait.c | 44 +++++++++++-----------
> mm/filemap.c | 4 +-
> net/sunrpc/sched.c | 4 +-
> 14 files changed, 150 insertions(+), 126 deletions(-)
prev parent reply other threads:[~2013-12-06 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 15:19 [RFC 0/1] wait queue head; locking considerations Paul Gortmaker
2013-12-06 15:19 ` [PATCH 1/1] waitq: abstract out locking/unlocking waitq head operations Paul Gortmaker
2013-12-06 16:34 ` Kirill Tkhai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7411386347644@web22m.yandex.ru \
--to=tkhai@yandex.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox