public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Zhang Rui <rui.zhang@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] cpufreq: intel_pstate: Handle powersave governor correctly in the passive mode with HWP
Date: Thu, 05 Nov 2020 19:17:54 +0100	[thread overview]
Message-ID: <7417968.Ghue05m4RV@kreacher> (raw)

Hi,

Even after the changes made very recently, the handling of the powersave
governor is not exactly as expected when intel_pstate operates in the
"passive" mode with HWP enabled.

Namely, in that case HWP is not limited to the policy min frequency, but it
can scale the frequency up to the policy max limit and it cannot be constrained
currently, because the governor has no way to tell the driver how much room
there is for adjustments around the target frequency passed to it.

For this reason, patch [1/2] introduces new policy parameters, target_min and
target_max, that can be used by the governor to pass that information to the
driver and modifies the powersave and peformance governors to use them.

Patch [2/2] modifies intel_pstate to take them into account so as to fix the
powersave governor issue, but they may be applicable for other purposes in the
future (eg. if the driver is updated to pass the "desired" P-state to the HWP
logic instead of just setting the HWP floor to the target one, both the
powersave and performance governors will need target_min and target_max to
basically work as documented).

Thanks!




             reply	other threads:[~2020-11-05 18:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 18:17 Rafael J. Wysocki [this message]
2020-11-05 18:23 ` [PATCH 1/2] cpufreq: Introduce target min and max frequency hints Rafael J. Wysocki
2020-11-06  1:49   ` Doug Smythies
2020-11-06 10:07   ` Viresh Kumar
2020-11-06 17:02     ` Rafael J. Wysocki
2020-11-09  4:39       ` Viresh Kumar
2020-11-09 12:27         ` Rafael J. Wysocki
2020-11-05 18:25 ` [PATCH 2/2] cpufreq: intel_pstate: Take target_min and target_max into account Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7417968.Ghue05m4RV@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox