From: Tobias Deiminger <tobias.deiminger@linutronix.de>
To: Lee Jones <lee@kernel.org>
Cc: pavel@kernel.org, eajames@linux.ibm.com, riku.voipio@iki.fi,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: pca9532: don't stop blinking for non-zero brightness
Date: Tue, 31 Mar 2026 22:23:31 +0200 [thread overview]
Message-ID: <7425682.G0QQBjFxQf@schlupp> (raw)
In-Reply-To: <20260331094730.GC3241346@google.com>
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
Am Dienstag, 31. März 2026, 11:47:30 Mitteleuropäische Sommerzeit schrieb Lee Jones:
> On Sat, 21 Mar 2026, Tobias Deiminger wrote:
> [...]
> > --- a/drivers/leds/leds-pca9532.c
> > +++ b/drivers/leds/leds-pca9532.c
> > @@ -184,6 +184,8 @@ static int pca9532_set_brightness(struct led_classdev *led_cdev,
> >
> > if (value == LED_OFF)
> > led->state = PCA9532_OFF;
> > + else if (led->state == PCA9532_PWM1)
> > + return 0; /* non-zero brightness shall not stop HW blinking */
>
> Comments should start with a capital letter.
>
> Also, as the final 'else' statement uses braces, should we perhaps take the
> opportunity to add braces to all branches of this conditional block?
Thanks for taking a look, sounds reasonable. Will adjust the comment and K&R-ify the
hunk in v2.
- Tobias
> > else if (value == LED_FULL)
> > led->state = PCA9532_ON;
> > else {
> >
> > base-commit: b2c87f5e98cd88095dbc6802197526703d5e4e48
>
>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-03-31 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 10:21 [PATCH] leds: pca9532: don't stop blinking for non-zero brightness Tobias Deiminger
2026-03-31 9:47 ` Lee Jones
2026-03-31 20:23 ` Tobias Deiminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7425682.G0QQBjFxQf@schlupp \
--to=tobias.deiminger@linutronix.de \
--cc=eajames@linux.ibm.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox