From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6A0644DB69; Tue, 31 Mar 2026 20:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774988617; cv=none; b=SDx4p0w861n21pZ3JWN5BPQqmk4KhcTpoUCiAYf5ztAnoqNiQsOUl29xN1hBGWMiOsrE/yZKEEGeBpc78WxxppVopkd6aXkptgcaj41EXyt2P95XXxL9dywWU+q51RGuwChueSoiBu0yq5E+KOcrVarfv6f6FrPd8mWOGDMP2Qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774988617; c=relaxed/simple; bh=VOGMHVm3mRA42ZUHG5tlG0ubSoPynlOJXSvDfHRuIKo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rw7g8kTWqQJlXKdjsSM/KOHPs8T/K5tpxPqwI+hPimQenZd0tp1WfNs8QJJGMZAv8nvjlkkXZAUoLTGhe+F0YIWeel062bw8uOQYh1lsa6ELxp8FqBHe04nonN7VxAlIxL0EgJ55RgnfgCywLwOVfVqGeR+BnG3eXj3jPgfSFKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=lWiHmIX3; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=JJmhO17z; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="lWiHmIX3"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="JJmhO17z" From: Tobias Deiminger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1774988614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lYimr6WepS9kou2sOosB6BFu771qSPlPLJB8yiaWuWg=; b=lWiHmIX36sejOqB9TQTl+kwWNZIEUAXdssMTqFuP2wVqaA2kxvbBzvKhH+vkGzks7RbYnz G4kx+qBhpEG8F8Dd7xJYzuX1OfbipIUNC5+9GG744u8CQRkAzKF+qi3xV83zfsAIXr3RuR iYfZcnjJN1AeF2C+JFhZODjwCX5Ry8+mIH2r+PgBQrnGkAZ2lskIhGkO+YeoMjXniKp59s cplX6l2JE4DTCOLECF7r6QulS3xHITRsnay4dV1KX7XT2DOgE+JkQDA/mX11nHo/CQvVr0 IKO3+YLP+MCKG+LWdPrknAd8roHBl3trxJnmVtUHdKipXxURrM75KfMEcXd1bA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1774988614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lYimr6WepS9kou2sOosB6BFu771qSPlPLJB8yiaWuWg=; b=JJmhO17zFq3i6lkpVnnNoa8IY7EqSLd3gof5br7OahsFBidc2OPhpXp71RroPwY7eQljNc XRsJeHR4arzMlpBA== To: Lee Jones Cc: pavel@kernel.org, eajames@linux.ibm.com, riku.voipio@iki.fi, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: pca9532: don't stop blinking for non-zero brightness Date: Tue, 31 Mar 2026 22:23:31 +0200 Message-ID: <7425682.G0QQBjFxQf@schlupp> Organization: Linutronix GmbH In-Reply-To: <20260331094730.GC3241346@google.com> References: <20260321102121.1563365-1-tobias.deiminger@linutronix.de> <20260331094730.GC3241346@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7479015.4vTCxPXJkl"; micalg="pgp-sha512"; protocol="application/pgp-signature" --nextPart7479015.4vTCxPXJkl Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Tobias Deiminger To: Lee Jones Date: Tue, 31 Mar 2026 22:23:31 +0200 Message-ID: <7425682.G0QQBjFxQf@schlupp> Organization: Linutronix GmbH In-Reply-To: <20260331094730.GC3241346@google.com> MIME-Version: 1.0 Am Dienstag, 31. M=C3=A4rz 2026, 11:47:30 Mitteleurop=C3=A4ische Sommerzeit= schrieb Lee Jones: > On Sat, 21 Mar 2026, Tobias Deiminger wrote: > [...] > > --- a/drivers/leds/leds-pca9532.c > > +++ b/drivers/leds/leds-pca9532.c > > @@ -184,6 +184,8 @@ static int pca9532_set_brightness(struct led_classd= ev *led_cdev, > > =20 > > if (value =3D=3D LED_OFF) > > led->state =3D PCA9532_OFF; > > + else if (led->state =3D=3D PCA9532_PWM1) > > + return 0; /* non-zero brightness shall not stop HW blinking */ >=20 > Comments should start with a capital letter. >=20 > Also, as the final 'else' statement uses braces, should we perhaps take t= he > opportunity to add braces to all branches of this conditional block? Thanks for taking a look, sounds reasonable. Will adjust the comment and K&= R-ify the hunk in v2. =2D Tobias > > else if (value =3D=3D LED_FULL) > > led->state =3D PCA9532_ON; > > else { > >=20 > > base-commit: b2c87f5e98cd88095dbc6802197526703d5e4e48 >=20 >=20 --nextPart7479015.4vTCxPXJkl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEKUF1IxSAivls6X6ly2PCe21rOcoFAmnMLUMACgkQy2PCe21r Ocqz8w/+Op2M0MLdQEQ4eW4/Bfq7/FoId0MhiqRNWc8jKS7KrLQr4FA9FmEi2Vlp vo4Xiq1mDEoq/Ps4hOQz6M2f0iLag20bCeI1vABkxwchnzmSfKUjKW+VKOD3M5mi ZOABBh8c9S4S3TPOpV4hD0NT9pirBY8mh8r52Y/oH5HKBS5AV5qVg4pFeLbiAwDj IuU/AUwcUcu4VLGlGtGPHH4F+PEpM7CEG5xGNtKAfD8qSOpwgww+I3WS0E7ybflp Pqq/nlln60YyTzt93pj2knOpNp5W69r4MUKg3D0a2cDN13aqg8eRwdK5RcSqylUU qSwmSx5BPsNlSSNxZQvuf2xYWs3zZQ5Zgk0vVkj9OsThwuoU6YEDtPGMpReI2HgY grS3NfrSQulRMPhYg4Cvdq5wcHsYa/tTIN3PQrjs0tOJwN9VSO9KFND8TUh18FDT xobZOH8kfGTjTQxrRIogHqsdtS7OQuulLcG/KBSBpl6pqO1UTsnl7lDiObCq8ZV/ UG0P12uvBY//1bZ48ieUUUzpSq2fyBrDYt9swNyP8rB0LAZkCj48qzia+cAeVK0T EtRPBYvEbq9JEVS5GgsLdNmKxL7L4YgNca8k00M9cMb7xlDA9VAnj/zuZr68YfDW /c/D46jSNStNSgByLFU0JkiLpIOhMnEuvVMktUuNvErjDQfJ38s= =rlZD -----END PGP SIGNATURE----- --nextPart7479015.4vTCxPXJkl--