From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0EE443D517 for ; Wed, 6 May 2026 14:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079012; cv=none; b=UsLJnGwqkeDueVhKGE9nO9acEegaf4RZBaaX/bb1tLvMUGDsMpPosMtQu2rGTG6OHomhWmGhg7zy+3sYTuexjaEGU1ZMv3++ZZbSUvlhIZE6TUP7EypLdnMJ8bU3RqtCR7dFI3zt+OWnhOAl1XLa9v8oSSnPRp3flVU2pjzE36k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079012; c=relaxed/simple; bh=E/7Hn0lBRsokKc6OpKls9FgRkgsCMpy/r+V2ptQbSuY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=E1REhRX+2mKWtZyAzrVUdVcTbogOcMlbOtbZ3L1FSNFWu2SQNKn0xSxQrnclqfaPWlbcdXdtOLaz0Ma+FVNb7hpqmGd4N2x+QxsQ4B+28QShX1hhYC6BslQMdDvHQCXiqF6eZYJhxLfrRxZqU3rinNukqXteUPFCN1GxKSFfXGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tUVAwgY7; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tUVAwgY7" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43eb05b1875so3518559f8f.3 for ; Wed, 06 May 2026 07:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778079009; x=1778683809; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=iNlQdkQkqMvv6TX3zSIUZJDpuOz3OCXPy5mPofQZIh8=; b=tUVAwgY7dq/fY4xocAXkyo5rSBv5tVBscixR/+jUDJO1xsp+0rcspglv6ZFL0Ky61U g6IQYnCzC2lAG3kUx4h0lTy0StJImHoalprbGliL+wHMEZBLRSfgaxXpBF0NX66n9lFK nM0UbKMxEw1/KBEzsVtjezdkrQtLTlhvzJXRPAWEYMesLjsH/uunj5OEA69VohOHBI6s v9OaTmNrdSgh2Pq64Oywklp74Ivp1omUC5EZY+nnKRlHmKMPcFeOkJI2q+lk/+BgMjk2 Yu+L1bHo0IUfDS+z7jPSAUJBkxXQvoFPxzsr5PzTB9EtnoQf5ZP3bYK2oKXxYiuOwvEx FmZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778079009; x=1778683809; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iNlQdkQkqMvv6TX3zSIUZJDpuOz3OCXPy5mPofQZIh8=; b=Ucb305OsDP7b3DUTq/TBAFfWbHw3LzVVPzQWnWlysuDrrQiKFh6eowmDERxZ91unLl 06sQSf7E2T7rCXf03sLRSVHdIGWiQeIS58W9PFZ971DLXExO5pzDp1IXFeNk12L25qqx wRc1Aza1Kz2QPEIJPyJIlvHDEt26Nyy38EDBaUeYFP5RMv7n5ixPP2qX+SjAtzRSXPfM CkynVsU3RHEvSY4pwfbCptI7dKNTv0ek6jEGMstXJb+8MwFnNB+wnhm74pzYf0ePu1hi 1dk4V5eJXJVjR+OSrRejThY8sHd9lxPnJycbSshDbQIFNSpvydlQfB0CwX6oWVcW1HHl /+3g== X-Forwarded-Encrypted: i=1; AFNElJ9ki42xkgDRQrsANKGyJISU8/W2Yzk/LJh02em1OT/lq84siv+eQCdx00AgeanBczuyJItYkiVdmoUoJew=@vger.kernel.org X-Gm-Message-State: AOJu0YzwRgi3mXxZfQx1bzjjI7att01GAAXz39gHrobeM+zDvX/rwg1f LPUwRBMhMK+uy3XS+p3q+tzjM/XtqHReBUU0OqtNylrOIPRkPA+IjvHTi4PR5jvQhGM= X-Gm-Gg: AeBDiesSdGurFi/j4H7pNqjQm4miQETYMWMS60O+sV5WaodxijvLuI7/XHZ9lsXJdTI ZLB6tCOXvXr/95WJBretRcp4qOGWNod2BxL1aUVZ8UpzczY3VtGUbwc0MKs+M82cz6DGqLPGdwE BwfXDG47pO5ogXLK86DXefiO9279v+QPFaxEY9xeSDv4izPhwG4Fv+NSZ2yRNe0Ls0u63Bfq38V WiXzpZsmc7Pr90NCzty43LIUDPMY0U/bZB+u28P3PEolH87EWPwlaJF/yPMCZ7cdC5NiC4Jnn8b 12QG2U0/eigKPnAjvdHKOftp7RpSQ+9g5oLtoCp/cFlfmWXD7/n3UFXsjp5mBdN0nJYeqUBdWlQ KHXBskjOWm+biL1Gt5OLFYHqxIVcCuGBCiArGUAI+499vry1fO8BCcDCAQMwj5RJrKVVJhfzAYz Yx49tRC/IpCdjVohwdnnyBlFFYtaMYoUJ7Y3bk2SxRpKZ7x643RComioaSZsYUJnC6A6hLta9Cy bsfWKYSAngmYgvOuf6vciuPCsJ3 X-Received: by 2002:a05:6000:268a:b0:451:3b12:9bca with SMTP id ffacd0b85a97d-4515ce1cde3mr6569525f8f.25.1778079009130; Wed, 06 May 2026 07:50:09 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:5798:67fd:c866:b378? ([2a01:e0a:106d:1080:5798:67fd:c866:b378]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45052483166sm12894076f8f.7.2026.05.06.07.50.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 07:50:06 -0700 (PDT) Message-ID: <7430e331-5bc4-4814-baf1-e87a9104045f@linaro.org> Date: Wed, 6 May 2026 16:50:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v4 06/16] phy: rockchip: usbdp: Add missing mode_change update To: Sebastian Reichel , Vinod Koul , Heiko Stuebner , Frank Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Yan , Dmitry Baryshkov , Yubing Zhang , Alexey Charkov , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, devicetree@vger.kernel.org References: <20260428-rockchip-usbdp-cleanup-v4-0-7775671ece22@collabora.com> <20260428-rockchip-usbdp-cleanup-v4-6-7775671ece22@collabora.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260428-rockchip-usbdp-cleanup-v4-6-7775671ece22@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/28/26 18:13, Sebastian Reichel wrote: > rk_udphy_set_typec_default_mapping() updates the available modes, > but does not set the mode_change as required. This results in > missing re-initialization and thus non-working DisplayPort. > > Fix this issue by introducing a new helper to update the available > modes. > > Signed-off-by: Sebastian Reichel > --- > drivers/phy/rockchip/phy-rockchip-usbdp.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c > index 97e53b933225..febc148a754e 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -619,6 +619,15 @@ static void rk_udphy_dp_hpd_event_trigger(struct rk_udphy *udphy, bool hpd) > rk_udphy_grfreg_write(udphy->vogrf, &cfg->vogrfcfg[udphy->id].hpd_trigger, hpd); > } > > +static void rk_udphy_mode_set(struct rk_udphy *udphy, u8 mode) > +{ > + if (udphy->mode == mode) > + return; > + > + udphy->mode_change = true; > + udphy->mode = mode; > +} > + > static void rk_udphy_set_typec_default_mapping(struct rk_udphy *udphy) > { > if (udphy->flip) { > @@ -649,7 +658,7 @@ static void rk_udphy_set_typec_default_mapping(struct rk_udphy *udphy) > gpiod_set_value_cansleep(udphy->sbu2_dc_gpio, 1); > } > > - udphy->mode = UDPHY_MODE_DP_USB; > + rk_udphy_mode_set(udphy, UDPHY_MODE_DP_USB); > } > > static int rk_udphy_orien_sw_set(struct typec_switch_dev *sw, > @@ -1385,10 +1394,7 @@ static int rk_udphy_typec_mux_set(struct typec_mux_dev *mux, > usleep_range(750, 800); > rk_udphy_dp_hpd_event_trigger(udphy, true); > } else if (data->status & DP_STATUS_HPD_STATE) { > - if (udphy->mode != mode) { > - udphy->mode = mode; > - udphy->mode_change = true; > - } > + rk_udphy_mode_set(udphy, mode); > rk_udphy_dp_hpd_event_trigger(udphy, true); > } else { > rk_udphy_dp_hpd_event_trigger(udphy, false); > Reviewed-by: Neil Armstrong Thanks, Neil