From: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
andriy.shevchenko@intel.com, cezary.rojewski@intel.com,
gustaw.lewandowski@intel.com
Subject: Re: [PATCH 2/2] tracing: Use seq_buf_hex_dump() to dump buffers
Date: Thu, 7 Nov 2019 13:18:08 +0100 [thread overview]
Message-ID: <743a0466-38ea-d8c2-8954-e5ca72c8b943@linux.intel.com> (raw)
In-Reply-To: <20191106035512.3ff7bc20@grimm.local.home>
On 2019-11-06 9:55, Steven Rostedt wrote:
> On Wed, 6 Nov 2019 07:27:40 +0100
> Piotr Maziarz <piotrx.maziarz@linux.intel.com> wrote:
>
>> Without this, buffers can be printed with __print_array macro that has
>> no formatting options and can be hard to read. The other way is to
>> mimic formatting capability with multiple calls of trace event with one
>> call per row which gives performance impact and different timestamp in
>> each row.
>>
>> Signed-off-by: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>> ---
>> include/linux/trace_events.h | 5 +++++
>> include/linux/trace_seq.h | 4 ++++
>> include/trace/trace_events.h | 6 ++++++
>> kernel/trace/trace_output.c | 15 +++++++++++++++
>> kernel/trace/trace_seq.c | 30 ++++++++++++++++++++++++++++++
>> 5 files changed, 60 insertions(+)
>>
>
> I'd like to see in the patch series (patch 3?) a use case of these
> added functionality. Or at least a link to what would be using it.
>
> Thanks!
>
> -- Steve
>
ASoC: Intel is an initial recipient for this feature. I have a patch for
this, but it should be also sent to alsa-devel mailing list, and since
hex_dump tracing isn't there yet I'm not sure how this patch series
should be sent.
Best regards,
Piotr Maziarz
next prev parent reply other threads:[~2019-11-07 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 6:27 [PATCH 1/2] seq_buf: Add printing formatted hex dumps Piotr Maziarz
2019-11-06 6:27 ` [PATCH 2/2] tracing: Use seq_buf_hex_dump() to dump buffers Piotr Maziarz
2019-11-06 8:55 ` Steven Rostedt
2019-11-07 12:18 ` Piotr Maziarz [this message]
2019-11-06 8:53 ` [PATCH 1/2] seq_buf: Add printing formatted hex dumps Steven Rostedt
2019-11-06 9:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743a0466-38ea-d8c2-8954-e5ca72c8b943@linux.intel.com \
--to=piotrx.maziarz@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=cezary.rojewski@intel.com \
--cc=gustaw.lewandowski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox