public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: 함명주 <myungjoo.ham@samsung.com>
To: "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
	"cbouatmailru@gmail.com" <cbouatmailru@gmail.com>
Subject: Re: RE: [Power-supply]: Error handling in max17042_battery.c
Date: Mon, 29 Aug 2011 05:58:13 +0000 (GMT)	[thread overview]
Message-ID: <7455484.255921314597492899.JavaMail.weblogic@epml19> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1165 bytes --]

I guess your spam filter filtered out my reply..?

The reply posted 3 days ago: https://lkml.org/lkml/2011/8/26/32

In short, please go ahead.


Cheers
MyungJoo

------- Original Message -------
Sender : Pallala, Ramakrishna<ramakrishna.pallala@intel.com>
Date : 2011-08-29 14:30 (GMT+09:00)
Title : RE: [Power-supply]: Error handling in max17042_battery.c

> Hi All,
> 
> I am working on the I2C based max17042 fuel gauge driver
> Which is drivers/power/max17042_battery.c
> 
> In max17042_get_property(...), the values returned by
> Max17042_read_reg are directly assigned to the variables,
> even if the read results in an error. Shouldn't we check
> for the 'correctness' of the returned values and then
> assign them ? Can I submit a patch to change this ?
> 
> Or Is this done intentionally ?

Any inputs on this?

Thanks,
Ram



 MyungJoo Ham (ÇÔ¸íÁÖ)
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

                 reply	other threads:[~2011-08-29  5:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7455484.255921314597492899.JavaMail.weblogic@epml19 \
    --to=myungjoo.ham@samsung.com \
    --cc=cbouatmailru@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ramakrishna.pallala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox