From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755442AbdEEVLC (ORCPT ); Fri, 5 May 2017 17:11:02 -0400 Received: from mout.web.de ([212.227.15.3]:51638 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbdEEVLA (ORCPT ); Fri, 5 May 2017 17:11:00 -0400 Subject: [PATCH 7/7] kernel-trace: Delete an error message for a failed memory allocation in create_trace_uprobe() From: SF Markus Elfring To: Ingo Molnar , Steven Rostedt Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Message-ID: <74587923-6261-8177-bff3-57cff57b8e87@users.sourceforge.net> Date: Fri, 5 May 2017 23:10:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:5ss0TvQ4HLwjrFzcg92HxkuoE5EhMvne9YqDejPuaTdGFHmTDZv qq3r/pTwuoPKh/JWD4omNF0GUtWcQE+wT5JzZ4pNv5VXuL0U74w8fagq02A6PIovjyPJY4U MdcJ6VzDQo9HI1Tev9nWXELh9oOYdsIlbXC9xcKc0Lnbx1mSoh/MRrltk9MxuFu01WEGGZW 14wfzbimBBHMDo7kI0Geg== X-UI-Out-Filterresults: notjunk:1;V01:K0:om7rIifFejs=:BK2EkfTfPKkhtUXhcvzaeM rXkpz8ZdQQt2kptggtOefCIY03E5eBSdh1IKS9ptHbkdop9KjrSBkd0Lu2alLgmrlaO7jktKE EzPBrhYYvVsFhq9TbJ+LYJ3tbUDfynEqE1ekMQPcS/ITNGJ8F/a0Z8WmU4PAjtCNvEYjIQd9F 3AeMsQejKeI7sQnoaWQbfQxJNPJq0kqLdx23nAMHFHI+jt4mLjOwLi3VhXJ+T49Di+D0fnn6b Y8o3rEYB0OrWyvizNB95Z8orftk1cVq6lGMJ7wbuXREg97dXsvPtSVoioM43Y3RYAUlqgCHvT +7l/Q8vqxoAC1l9+mWfn2yaVswzcbB+DFQ0jnZA98IxA9pIjEHOzDcSKQsA7l3LgpYDXIeXKX qhnVaZNwZolpQC6CbWwP/1SeJHMXS4+//Tmplf9mVdj7PTawtWRRWrBpVEgXabJitAsJma4Xv 4TEbeu6dR27vifXeOuJvMX9D1ydF2j69/CmYFQybNCjNLzzrLw1Rq9hFRo0sSbHDkj+LssxQJ j4E1PGXt1a1bXUtspq1dZ9916ZHiHam4wwyO2ald27zuwwaetGcz+McZR9hwqqZiJKZcUv2sl LvI3cTIisoDsYxK3aXwJjES1bKo6GQOOUr8BW4BOP50UaDMiGvWzTMQvwjsHefHBzxRAVNQcU ytfexgTZjLAa6aXwd0C24u6yK0OSvHiAu8voFyJQx1/1OG5MDa9pSNhTFiMDFtCr4PFlriya1 Yr80K/LLS7J2yqzl1VK6waGiZohEv6Z9CIxHGz2h0aGo0ehgpgjma2NJ2zoLJw0CTW+Nq9NPj ybFmA5b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 22:38:51 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- kernel/trace/trace_uprobe.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index e9c1865f7397..d19fa2a6cc7b 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -490,9 +490,7 @@ static int create_trace_uprobe(int argc, char **argv) tu->offset = offset; tu->inode = inode; tu->filename = kstrdup(filename, GFP_KERNEL); - if (!tu->filename) { - pr_info("Failed to allocate filename.\n"); ret = -ENOMEM; goto error; } -- 2.12.2