From: Gao Xiang <hsiangkao@aol.com>
To: Pavel Zemlyanoy <zemlyanoy@ispras.ru>
Cc: Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>,
ldv-project@linuxtesting.org, devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison
Date: Fri, 31 Aug 2018 00:09:34 +0800 [thread overview]
Message-ID: <747d9c74-02cd-fa39-9870-ae17dbddf366@aol.com> (raw)
In-Reply-To: <1535642042-5336-2-git-send-email-zemlyanoy@ispras.ru>
Hi Pavel,
On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch checks by
> to NULL comparison.
>
> The patch fixes 5 checks of type:
> "Comparison to NULL could be written".
>
> Signed-off-by: Pavel Zemlyanoy <zemlyanoy@ispras.ru>
Sorry about the late reply. I am on vacation now.
Personally, I use "== NULL" or "!= NULL" on purpose, since it is more
emphasized than the checkpatch.pl suggested way, and I tend to use the nullptr explicitly.
BTW, It seems other filesystems still use "== NULL" or "!= NULL" explicitly, too, eg:
xfs, ext4, ext2, ocfs2, etc... You could 'grep' in the fs directory...
Other commits look good for me at glance.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2018-08-30 16:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 15:13 [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c Pavel Zemlyanoy
2018-08-30 15:13 ` [PATCH 2/6] staging: erofs: formatting fix to NULL comparison Pavel Zemlyanoy
2018-08-30 16:09 ` Gao Xiang [this message]
2018-08-30 16:32 ` Gao Xiang
2018-08-31 3:29 ` Chao Yu
2018-08-31 9:41 ` Dan Carpenter
2018-09-03 1:59 ` Chao Yu
2018-09-03 4:23 ` Gao Xiang
2018-09-03 1:48 ` Chao Yu
2018-08-30 15:13 ` [PATCH 3/6] staging: erofs: formatting spaces around '-' Pavel Zemlyanoy
2018-09-03 1:48 ` Chao Yu
2018-09-03 4:32 ` Gao Xiang
2018-08-30 15:14 ` [PATCH 4/6] staging: erofs: formatting add spaces arround '*' Pavel Zemlyanoy
2018-09-03 1:48 ` Chao Yu
2018-09-03 4:33 ` Gao Xiang
2018-08-30 15:14 ` [PATCH 5/6] staging: erofs: formatting alignment parenthesis Pavel Zemlyanoy
2018-09-03 1:49 ` Chao Yu
2018-09-03 4:43 ` Gao Xiang
2018-08-30 15:14 ` [PATCH 6/6] staging: erofs: fix 1 warning and 9 checks Pavel Zemlyanoy
2018-09-03 1:49 ` Chao Yu
2018-09-03 4:50 ` Gao Xiang
2018-09-03 1:47 ` [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c Chao Yu
2018-09-03 4:30 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=747d9c74-02cd-fa39-9870-ae17dbddf366@aol.com \
--to=hsiangkao@aol.com \
--cc=devel@driverdev.osuosl.org \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
--cc=zemlyanoy@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox