Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2732 image sensor

[Krzysztof Kozlowski <krzk@kernel.org>]

On 18/12/2025 19:15, Walter Werner Schneider wrote:
> +  avdd-supply:
> +    description: Analog Domain Power Supply
> +
> +  dovdd-supply:
> +    description: I/O Domain Power Supply
> +
> +  dvdd-supply:
> +    description: Digital Domain Power Supply
> +
> +  pwdn-gpios:

Use name from gpio-consumer-common, so "powerdown-gpios".

> +    maxItems: 1
> +    description: Reference to the GPIO connected to the pwdn pin. Active high.

high?

> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Reference to the GPIO connected to the reset pin. Active high.

Are you sure this is active high?

> +
> +  port:
> +    description: MIPI CSI-2 transmitter port
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2
> +          link-frequencies: true

Drop

> +          remote-endpoint: true

Drop

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +          - remote-endpoint

Drop remote endpoint

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - avdd-supply
> +  - dovdd-supply
> +  - dvdd-supply
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ov2732: camera@36 {
> +            compatible = "ovti,ov2732";
> +            reg = <0x36>;
> +            clocks = <&ov2732_clk>;
> +            clock-names = "xvclk";
> +
> +            avdd-supply = <&ov2732_avdd>;
> +            dovdd-supply = <&ov2732_dovdd>;
> +            dvdd-supply = <&ov2732_dvdd>;
> +
> +            pwdn-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>;
> +            reset-gpios = <&gpio0 8 GPIO_ACTIVE_LOW>;

And here (probably correct) active low?



Best regards,
Krzysztof