From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kaison Deng <dkx@t-chip.com.cn>
Cc: Rob Herring <robh@kernel.org>, Jimmy Hon <honyuenkwun@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Wayne Chou <zxf@t-chip.com.cn>,
Quentin Schulz <quentin.schulz@cherry.de>,
Dragan Simic <dsimic@manjaro.org>,
Jonas Karlman <jonas@kwiboo.se>, FUKAUMI Naoki <naoki@radxa.com>,
Peter Robinson <pbrobinson@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT
Date: Wed, 10 Sep 2025 09:10:38 +0200 [thread overview]
Message-ID: <74b42187-ee90-4499-a93d-800c3a55c5e8@kernel.org> (raw)
In-Reply-To: <55CC0521CC5B0671+91c4b933e5c5f604ade4f7e314be6fe49efc9e99.camel@t-chip.com.cn>
On 10/09/2025 07:47, Kaison Deng wrote:
>>> + - description: Firefly ROC-RK3588-RT
>>> + items:
>>> + - const: firefly,roc-rk3588-rt
>>
>> That's just enum with ROC-RK3576-PC. BTW, all these descriptionis are
>> completely redundant. Actually getting harmful, because copy+paste of
>> the same is only obfuscating code.
>>
>> Best regards,
>> Krzysztof
>>
>>
>
> The ROC-RK3576-PC is based on the RK3576 SoC (4*Cortex-A72 + 4*Cortex-
> A53). The ROC-RK3588-RT is based on the RK3588 SoC (4*Cortex-A76 +
Uh, you are right, somehow I mixed up numbers.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-10 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 1:31 [PATCH v2 0/2] Add support for Firefly ROC-RK3588-RT Kaison Deng
2025-09-09 1:31 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add " Kaison Deng
2025-09-09 7:22 ` Krzysztof Kozlowski
2025-09-10 5:47 ` Kaison Deng
2025-09-10 7:10 ` Krzysztof Kozlowski [this message]
2025-09-09 1:31 ` [PATCH v2 2/2] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT Kaison Deng
2025-09-09 12:31 ` Andrew Lunn
2025-09-10 2:55 ` Kaison
2025-09-10 12:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b42187-ee90-4499-a93d-800c3a55c5e8@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkx@t-chip.com.cn \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=pbrobinson@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=zxf@t-chip.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox