From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C214A3491DB for ; Fri, 16 Jan 2026 04:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768539026; cv=none; b=rZK9/O6rD6YzQIOLAyTtWTNWVWr8dPI4Io8NbXQco1S7sTrfdvnsnFc0STF1g8j1/kmp5WpPmaS+GryveOF4C05TD1nNyrfyk4eq+4vKdS0Ga7QGjhzru2cw+MVyTVEbidMhrIJb1AT7Jes6sccJastuAaAp2+Ur09LG8vwac9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768539026; c=relaxed/simple; bh=kiycUkgYcgP1rwT2HKpckX+ZMBlhPbMFV0u9l5UBtVA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=eyBv7AE3BKpipCFyf0nP3g8hZ+znWg/7aQSIdD1Z+MKZnis73PRRwRlDQXTdOpDZ/dzGOpCNHawsgBOoyKZPJdOWWqZKoDBJXuptOj+0h7Taf/hUKvN058R+6DsZeLhXyACynwDkOO9IBq4macFHsklBNqtwNpjSZMej6V/UwRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M1HAIxia; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M1HAIxia" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A9F3C116C6; Fri, 16 Jan 2026 04:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768539025; bh=kiycUkgYcgP1rwT2HKpckX+ZMBlhPbMFV0u9l5UBtVA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=M1HAIxiaNSgnnbYVvX2rbeJoR1ZrmdFrSF0BZoVYznoedvnk1t8YFNHgtCemyMQSX +KJ9gP08uqGsXTTby4RjAwcJdv5Ga7fxMJSSidWJlUCboGintOutstXE96HDpXrU3Z 6g+B7vDMTAyWUL/jNMsX+ps2XH49D9IWWcOA8Fn6SRWgKJby0JVaB66M3yf9GhNCIJ ZoOEW75IRfJkOpTbGY4I7qqSNc/XwjqY/yJ3hAMPEA6Mrz0+H5CMRBk5png7XO5uFG uLJXbFcnKt25JYpHIfBNGNRCpSmULQXLbyIoXI/W9QkdAD6HNVo8cDOxYT0KzkWs4F WksLORM4so+fw== Date: Thu, 15 Jan 2026 21:50:20 -0700 (MST) From: Paul Walmsley To: =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: Implement ARCH_HAS_CC_CAN_LINK In-Reply-To: <20251222-cc-can-link-riscv-v1-1-633e39e4a60d@linutronix.de> Message-ID: <74cdaaf4-598d-29f8-584a-3c6a242adee1@kernel.org> References: <20251222-cc-can-link-riscv-v1-1-633e39e4a60d@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-984989649-1768539025=:2705266" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-984989649-1768539025=:2705266 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Hi, On Mon, 22 Dec 2025, Thomas Weißschuh wrote: > The generic CC_CAN_LINK detection relies on -m32/-m64 compiler flags. > These are not supported by riscv compilers. > > Use architecture-specific logic using -mabi instead. > > Signed-off-by: Thomas Weißschuh > --- > arch/riscv/Kconfig | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 6b39f37f769a..b4c1f922eed5 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -25,6 +25,7 @@ config RISCV > select ARCH_ENABLE_SPLIT_PMD_PTLOCK if PGTABLE_LEVELS > 2 > select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE > select ARCH_HAS_BINFMT_FLAT > + select ARCH_HAS_CC_CAN_LINK > select ARCH_HAS_CURRENT_STACK_POINTER > select ARCH_HAS_DEBUG_VIRTUAL if MMU > select ARCH_HAS_DEBUG_VM_PGTABLE > @@ -1351,6 +1352,16 @@ config PORTABLE > config ARCH_PROC_KCORE_TEXT > def_bool y > > +config ARCH_CC_CAN_LINK > + bool > + default $(cc_can_link_user,-mabi=lp64d) if 64BIT > + default $(cc_can_link_user,-mabi=ilp32d) > + > +config ARCH_USERFLAGS > + string > + default "-mabi=lp64d" if 64BIT > + default "-mabi=ilp32d" > + Any reason why this patch shouldn't use the non-d ABI variants, as the rest of arch/riscv/Kconfig does? I suspect this may not work for !CONFIG_FPU builds. - Paul --8323329-984989649-1768539025=:2705266--