From: "Kars Mulder" <kerneldev@karsmulder.nl>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
"David Laight" <David.Laight@aculab.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Pavel Machek" <pavel@denx.de>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Oliver Neukum" <oneukum@suse.com>
Subject: Re: [PATCH] usb: core: fix quirks_param_set() writing to a const pointer
Date: Mon, 06 Jul 2020 15:58:17 +0200 [thread overview]
Message-ID: <74dc-5f032e00-69-5f1a6480@172803432> (raw)
In-Reply-To: <20200706130717.GA2276608@kroah.com>
On Monday, July 06, 2020 15:07 CEST, Greg Kroah-Hartman wrote:
> Just test for memory allocation failure and handle it properly, it isn't
> hard to do.
>
> 128 bytes on the stack can be a problem, don't get in the habit of doing
> so please.
Thank you for the clarification. The next version of my patch shall use
kstrdup() instead of copying to the stack.
prev parent reply other threads:[~2020-07-06 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 11:35 Writing to a const pointer: is this supposed to happen? Kars Mulder
2020-06-23 19:55 ` Pavel Machek
2020-06-24 12:34 ` Kars Mulder
2020-06-24 13:10 ` Greg Kroah-Hartman
2020-06-24 15:25 ` Kars Mulder
2020-06-27 10:24 ` David Laight
2020-07-01 23:03 ` Kars Mulder
2020-07-02 7:55 ` David Laight
2020-07-02 21:48 ` Kars Mulder
2020-07-03 8:13 ` David Laight
2020-07-03 13:23 ` Kars Mulder
2020-07-04 11:55 ` Pavel Machek
2020-07-05 21:53 ` [PATCH] usb: core: fix quirks_param_set() writing to a const pointer Kars Mulder
2020-07-06 10:34 ` Greg Kroah-Hartman
2020-07-06 12:57 ` Kars Mulder
2020-07-06 13:07 ` Greg Kroah-Hartman
2020-07-06 13:58 ` Kars Mulder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74dc-5f032e00-69-5f1a6480@172803432 \
--to=kerneldev@karsmulder.nl \
--cc=David.Laight@aculab.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox