From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C407C04A6B for ; Tue, 7 May 2019 01:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CF91206BF for ; Tue, 7 May 2019 01:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbfEGBk4 (ORCPT ); Mon, 6 May 2019 21:40:56 -0400 Received: from mga05.intel.com ([192.55.52.43]:4087 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbfEGBkz (ORCPT ); Mon, 6 May 2019 21:40:55 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 18:40:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,440,1549958400"; d="scan'208";a="149034370" Received: from speesari-mobl.amr.corp.intel.com (HELO [10.251.22.59]) ([10.251.22.59]) by orsmga003.jf.intel.com with ESMTP; 06 May 2019 18:40:53 -0700 Subject: Re: [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID To: Evan Green , Liam Girdwood , Mark Brown Cc: Naveen M , Sathya Prakash , Ben Zhang , Rajat Jain , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood References: <20190506225321.74100-1-evgreen@chromium.org> <20190506225321.74100-2-evgreen@chromium.org> From: Pierre-Louis Bossart Message-ID: <74e8cfcd-b99f-7f66-48ce-44d60eb2bbca@linux.intel.com> Date: Mon, 6 May 2019 20:40:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190506225321.74100-2-evgreen@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/6/19 5:53 PM, Evan Green wrote: > Add support for Intel Comet Lake platforms by adding a new Kconfig > for CometLake and the appropriate PCI ID. This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To the best of my knowledge SOF probes fine on CML and the known issues can be found on the SOF github [1]. Care to send the log of sudo lspci -s 0:1f.3 -vn ? [1] https://github.com/thesofproject/sof/issues?q=is%3Aopen+is%3Aissue+label%3ACML > > Signed-off-by: Evan Green > --- > > sound/soc/sof/intel/Kconfig | 16 ++++++++++++++++ > sound/soc/sof/sof-pci-dev.c | 4 ++++ > 2 files changed, 20 insertions(+) > > diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig > index 32ee0fabab92..0b616d025f05 100644 > --- a/sound/soc/sof/intel/Kconfig > +++ b/sound/soc/sof/intel/Kconfig > @@ -24,6 +24,7 @@ config SND_SOC_SOF_INTEL_PCI > select SND_SOC_SOF_CANNONLAKE if SND_SOC_SOF_CANNONLAKE_SUPPORT > select SND_SOC_SOF_COFFEELAKE if SND_SOC_SOF_COFFEELAKE_SUPPORT > select SND_SOC_SOF_ICELAKE if SND_SOC_SOF_ICELAKE_SUPPORT > + select SND_SOC_SOF_COMETLAKE if SND_SOC_SOF_COMETLAKE_SUPPORT > help > This option is not user-selectable but automagically handled by > 'select' statements at a higher level > @@ -179,6 +180,21 @@ config SND_SOC_SOF_ICELAKE > This option is not user-selectable but automagically handled by > 'select' statements at a higher level > > +config SND_SOC_SOF_COMETLAKE > + tristate > + select SND_SOC_SOF_CANNONLAKE > + help > + This option is not user-selectable but automagically handled by > + 'select' statements at a higher level > + > +config SND_SOC_SOF_COMETLAKE_SUPPORT > + bool "SOF support for CometLake" > + help > + This adds support for Sound Open Firmware for Intel(R) platforms > + using the Cometlake processors. > + Say Y if you have such a device. > + If unsure select "N". > + > config SND_SOC_SOF_HDA_COMMON > tristate > select SND_SOC_SOF_INTEL_COMMON > diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c > index b778dffb2d25..5f0128337e40 100644 > --- a/sound/soc/sof/sof-pci-dev.c > +++ b/sound/soc/sof/sof-pci-dev.c > @@ -353,6 +353,10 @@ static const struct pci_device_id sof_pci_ids[] = { > #if IS_ENABLED(CONFIG_SND_SOC_SOF_ICELAKE) > { PCI_DEVICE(0x8086, 0x34C8), > .driver_data = (unsigned long)&icl_desc}, > +#endif > +#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE) > + { PCI_DEVICE(0x8086, 0x02c8), > + .driver_data = (unsigned long)&cnl_desc}, > #endif > { 0, } > }; >