Re: [PATCH v2 03/24] MIPS: PCI: Use pci_enable_resources()

Thomas Bogendoerfer
2025-10-17T13:13:39Z

On Fri, Oct 17, 2025 at 01:58:13PM +0300, Ilpo Järvinen wrote:
> On Fri, 17 Oct 2025, Thomas Bogendoerfer wrote:
>
> > On Tue, Oct 14, 2025 at 03:41:42PM +0300, Ilpo Järvinen wrote:
> > > [...]
> > > It was "good enough" only because the arch specific
> > > pcibios_enable_resources() was lacking the check for whether the resource
> > > truly got assigned or not. The PIIX4 driver must worked just fine without
> > > those IO resources which is what most drivers do despite using
> > > pci(m)_enable_device() and not pci_enable_device_mem() (the latter
> > > doesn't even seem to come with m variant).
> >
> > will you send a v2 of the patch ?
>
> Without the the if ()? I can do that, I was unsure how people wanted to
> progress with this.

yes without the if(), thank you

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]