From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A683E275870 for ; Tue, 23 Dec 2025 13:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766497844; cv=none; b=G9/RulHxO1Ca5xpGmY7HZo6US01nDtw6r10GD6mtxUqjAvqStTLwGgI2xsMmXkBbKBD1K6UTNjtqEOc8BAHufyJIO5zv4gKoGU9uCoAsjY7bhTSSQuCxctRiPyFUolNhJUU3rVAACwu33ceMa+34M21niaT/BVsIYtvLaSHSGBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766497844; c=relaxed/simple; bh=JQTXS/wYMzvek+4ggAsosG0VXdWLW1tbpUHCZl693sk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oP28adCEB4TVCXu3m5FFrWrQrrHu4hDF8KI0arkBJfGf9DqWS6a5ca3IhxWQClwv1YkrF549J34yW4Kj+NSfThfMArR1mFzBS/AmYSnVqLJlLYFWTULOzY2yrkCgZ9fBN+g+vjQrYUprZk06v2VlfQjt9KBooIQIu3xZFoFwbUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FXJ5CAmr; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FXJ5CAmr" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so3228271f8f.2 for ; Tue, 23 Dec 2025 05:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766497841; x=1767102641; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GqeoU932E3jkcWropIRFkLF7YQVKeZWJseuKYTCW02o=; b=FXJ5CAmrPPp8x6CUz3PkkkzMXkCHTCIKTwWnTV1vK4+wXHaV7hagJn7ubgYlHZNYFn tIq59oJsdYLQM8AtiebtL00jJgww51vo94zRSsP+forXTGMGM16j6wDoJessSc3x4Q18 HC6CK1z30/w0ILrcErfJ1CLV7idlZnbtlae7xzLHLYMYI+BtjWanaUJO/65hyi+9Do3l Q+juMEEwN3A+FsamMTiEaMSdZHqJe5MIWntTNGLw46zGSRJBqP3b6zvI/7NNLjWMBte3 vfoAvxSrrqFz5ra/LcHnlltNk/tPVULhflCKbdG1+wMPiJaaXfO3uaK1aFpgOgser8AU D/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766497841; x=1767102641; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GqeoU932E3jkcWropIRFkLF7YQVKeZWJseuKYTCW02o=; b=b6g3Q9YetnOcCs7p2DUVk+a63vk87M2HKMNsUVjmRxThfsG+wPgyzEMwlmNloPdra8 1Y5VRmZhxpzaWFDi3UZI/0Cl0wKEld8xUR8ePXeNUaj4VU7dNk43f55n+99sKpns0Y/Q vKntUdYRQvhv+AKLcuI/89z/w02foCJmHvtO1z1oPc4ye/xq0uqaJu7Bo+W2AqqfqCj0 eXGVr3R6EwP8bHEka7OCzDGp8GSpNz9vKY3ycJqVh0S6Ype0E4wXzP3pC62/UKk35ExP l8RU/E5n/geXdJHfpXnyMI/ruyf5Rbhm1wdZ6nLTgO5WAO7IaOsduhN9SHOVA58q+sNv eRtA== X-Forwarded-Encrypted: i=1; AJvYcCWVLjf7clOS7TkXkCQ9TNcM9H/eI9kqjgYnfXPwkVYEFZb0bPQmDqAdwF9jguXCdcHYTEwh00SDDbm4JBg=@vger.kernel.org X-Gm-Message-State: AOJu0YynVgZxVZpz3dZDN7n8YSB5CSanoOlwYFVe1CGr1NGMKciLL0pW nyCk1p6GcM9giE8img8WR5fZqxkVaR6wzBddC45s436Qm/KHObEzqaExXv87ww== X-Gm-Gg: AY/fxX6gyjW+SjHTYfD36ods3TCrRUaBJbyhD+aFi2MKgOv1Z5EYTyCA14lSZRJMrB9 +MnMInk7z1dUcVp8V+QuoKM0wotFR8ZyGIp5IcXPkAZjTH2Kv9ETZwo6ZLHk9EAI15NB9i3SM8n ee5GUheCchRCSZlog9JC0UMGQxIB/b1B48LRUOqsHcQtqzQT6LUHsUIHAvCW7ctwdVzhXvzv1Uf FIsrPcj86/DhKBHC8YEtCKMRICFUM7umn24tDnyqlmVhLDW6tvpuGhBK48EvsOHeWaL7ooSlRW9 neFlR2fpwILzPQOvNUlKPHP/cqF2Ri6mC0gVY1VLwQUh7HDWuN2iD/Q8yLRUVrLgcVq3RWrlOFy FNzmPhQdcUgAfwfOZofi3sXLwpXrLKL5AvfVBg3CeGn67r+86dr3ascZ6QktZbCscKtOl8iP/8z MzeGmD/8FP9Inwr4kKsYhPiSc= X-Google-Smtp-Source: AGHT+IG8AsTo+t9sk0hU0othTg5pT8jTi5K0OjCjX+h2p6P+SMnZ3sYYS1W7tDwW8jnyO6+O/9AZsQ== X-Received: by 2002:a05:6000:611:b0:42f:b690:6788 with SMTP id ffacd0b85a97d-4324e4c1264mr16049308f8f.10.1766497840775; Tue, 23 Dec 2025 05:50:40 -0800 (PST) Received: from [192.168.1.121] ([176.206.93.222]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08d9sm28704414f8f.30.2025.12.23.05.50.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Dec 2025 05:50:40 -0800 (PST) Message-ID: <74f1a53d-3556-4e67-8dc2-2a86d6c52365@gmail.com> Date: Tue, 23 Dec 2025 14:50:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: asus-nb-wmi: add quirk_asus_ignore_fan for UX3405MA To: Tim Wassink Cc: Corentin Chary , "Luke D. Jones" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251221210218.12274-1-timwassink.dev@gmail.com> Content-Language: en-US, it-IT, en-US-large From: Denis Benato In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/22/25 11:44, Tim Wassink wrote: > On Sun, Dec 21, 2025 at 10:01 PM Denis Benato wrote: >> On 12/21/25 22:01, Tim Wassink wrote: >>> The ASUS Zenbook 14 (UX3405MA) uses a newer WMI interface for thermal >>> management that does not support the legacy WMI fan control methods. >>> Currently, this results in ENODEV (-19) errors in dmesg when the driver >>> attempts to fetch factory fan curve defaults. >>> >>> Add a quirk to use quirk_asus_ignore_fan to silence these errors and >>> signal that legacy fan control is intentionally unsupported, as thermal >>> policies are handled through the platform_profile interface. >> It is my understanding that this patch suppresses the error, >> while maintaining the current behavior in every other aspect, >> correct? > I am actually not sure anymore if this patch is ok, as it introduces a > trade-off regarding telemetry. > > While the patch successfully silences the ENODEV (-19) errors, I have > verified locally that it also inhibits the registration of the fan > telemetry in hwmon. This means the read-only 'fan1_input' (RPM) is no > longer available to the user. > > I initially followed the precedent of commit 82cc5c6c624c ("platform/x86: > asus-wmi: Ignore fan on E410MA"), which can be found here: > https://lore.kernel.org/all/20221221-asus-fan-v1-2-e07f3949725b@weissschuh.net/ > > Now I realize that case was specifically for a fanless system. The > UX3405MA does have a physical fan > which remains functional via the platform_profile (AIPT) interface > after this patch, as confirmed by stress testing. > > I thought this quirk was the standard way to handle it, but I am not > so sure anymore. Hi, I think what's happening is that asus-nb-wmi is binding multiple devices: for those that are unsupported the driver returns -ENODEV and the kernel, as a result, probes successive drivers for those devices that can't be bound. It's very likely that using that quirk prevents asus-nb-wmi to bind all devices, and this can very well result in what you are seeing... The only runtime problem is that an error appears in dmesg, right? The rest is working from what I can understand from your messages.  > Best regards, > Tim > > On Mon, Dec 22, 2025 at 3:54 AM Denis Benato wrote: >> >> On 12/21/25 22:01, Tim Wassink wrote: >>> The ASUS Zenbook 14 (UX3405MA) uses a newer WMI interface for thermal >>> management that does not support the legacy WMI fan control methods. >>> Currently, this results in ENODEV (-19) errors in dmesg when the driver >>> attempts to fetch factory fan curve defaults. >>> >>> Add a quirk to use quirk_asus_ignore_fan to silence these errors and >>> signal that legacy fan control is intentionally unsupported, as thermal >>> policies are handled through the platform_profile interface. >> It is my understanding that this patch suppresses the error, >> while maintaining the current behavior in every other aspect, >> correct? >>> Signed-off-by: Tim Wassink >>> --- >>> drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c >>> index 6a62bc5b02fd..eaa8abe506cb 100644 >>> --- a/drivers/platform/x86/asus-nb-wmi.c >>> +++ b/drivers/platform/x86/asus-nb-wmi.c >>> @@ -544,6 +544,15 @@ static const struct dmi_system_id asus_quirks[] = { >>> }, >>> .driver_data = &quirk_asus_zenbook_duo_kbd, >>> }, >>> + { >>> + .callback = dmi_matched, >>> + .ident = "ASUS Zenbook 14 UX3405MA", >>> + .matches = { >>> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >>> + DMI_MATCH(DMI_PRODUCT_NAME, "UX3405MA"), >>> + }, >>> + .driver_data = &quirk_asus_ignore_fan, >>> + }, >>> { >>> .callback = dmi_matched, >>> .ident = "ASUS ROG Z13",