From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965748AbdKQQDt (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Nov 2017 11:03:49 -0500
Received: from mailout1.samsung.com ([203.254.224.24]:50950 "EHLO
        mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933947AbdKQQDm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Nov 2017 11:03:42 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171117160340epoutp018f99a940f13a587b0a0a39ac9e851b08~36wgb6F240943909439epoutp014
X-AuditID: b6c32a46-46dff700000010ca-26-5a0f085aaac8
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Colin King <colin.king@canonical.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: sm501fb: fix potential null pointer
 dereference on fbi
Date: Fri, 17 Nov 2017 17:03:36 +0100
Message-id: <7500259.pPyNLB3SIs@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <20171110173231.24598-1-colin.king@canonical.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsWy7bCmhW40B3+Uwd9DjBa/V/eyWVz5+p7N
        YustaYsTfR9YLS7vmsNmceD0FGYHNo9ZDb1sHjtn3WX3uN99nMnj8ya5AJYoLpuU1JzMstQi
        fbsEroytL/awF3xmqZhyWqmB8RdzFyMnh4SAicSLs4vZQGwhgR2MEu8u2nYxcgHZ3xklls+a
        yd7FyAFWNOGTC0R8N6PEtSVb2SGcr4wSB+9MYgfpZhOwkpjYvooRpEFEQFPi/LkikBpmgY2M
        Ers3zGYEqREWiJbY29QOto1FQFVi0/oprCA2L1D9ob6tYDWiAl4SW/a1M4HYnAJ2ErfnfmaG
        qBGU+DH5HguIzSwgL7Fv/1RWCFtH4uyxdYwgyyQE1rBJbJt8gw3iNReJiavuQL0pLPHq+BZ2
        CFta4tmqjYwQ9nRGie2/JSCaNzNKrNo9AarIWuLw8YtQG/gkOg7/hQYFr0RHmxBEiYfEnZ+3
        WCFsR4lrK86wQkJlIqPE2aVrGScwys5CcvgsJIfPQnL4AkbmVYxiqQXFuempxUYFRnrFibnF
        pXnpesn5uZsYwclAy20H45JzPocYBTgYlXh4Kxj4o4RYE8uKK3MPMUpwMCuJ8M5YzhclxJuS
        WFmVWpQfX1Sak1p8iFGag0VJnLdu27UIIYH0xJLU7NTUgtQimCwTB6dUA+PWKjO73NXsJxw4
        F2btnTNd1vPwzikzPq0TWOX0a9q1kLfZ826oBm4u9X2nXrePl8Hw3QdjHv+3Am33FWNyc4RK
        9tUW8/E77hDTCI64Wnmz+sp5w017Qs6V95xNWvz+hou/y8qVb3ryz6v/ZZTubz8cmHmkNXuu
        p1Lh5it7J/K4XH/1cfK1k5ZKLMUZiYZazEXFiQC3xmANAgMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t9jAd0oDv4og8W7RS1+r+5ls7jy9T2b
        xdZb0hYn+j6wWlzeNYfN4sDpKcwObB6zGnrZPHbOusvucb/7OJPH501yASxRXDYpqTmZZalF
        +nYJXBlbX+xhL/jMUjHltFID4y/mLkYODgkBE4kJn1y6GLk4hAR2Mkp8/dPMDOF8ZZQ4Ouc0
        YxcjJwebgJXExPZVjCANIgKaEufPFYGEmQU2Mkps/5oFYgsLREvsbWpnA7FZBFQlNq2fwgpi
        8wKVH+rbCjZGVMBLYsu+diYQm1PATuL23M9QuyYzSkw88pMdokFQ4sfkeywQC+Ql9u2fygph
        a0ms33mcaQIj/ywkZbOQlM1CUraAkXkVo2RqQXFuem6xUYFRXmq5XnFibnFpXrpecn7uJkZg
        8G47rNW/g/HxkvhDjAIcjEo8vBUM/FFCrIllxZW5hxglOJiVRHhnLOeLEuJNSaysSi3Kjy8q
        zUktPsQozcGiJM7Ln38sUkggPbEkNTs1tSC1CCbLxMEp1cCYPy/ZkmlieY6aSXZe8rPGvaLl
        rAv8rU/P3BDmuHax8DvRKWv0vi3Ot3PYycRr/ztAMlBWuHrnrIyMV5sfHDbj5HJYsGC/39Eg
        o3NPzOUbr1qHyJVYhlZaLr/XmRfMNfVMnfSLYKuJQiGTTdU+fs7tiH73X7K92Wy65WGtlxfm
        xa0XvHP7tLUSS3FGoqEWc1FxIgB54yVeWgIAAA==
X-CMS-MailID: 20171117160338epcas2p459b7155d9ce5704d32cb1c21c278c344
X-Msg-Generator: CA
CMS-TYPE: 102P
X-CMS-RootMailID: 20171110173236epcas4p2e31777c5a06270f2aed64110fedf0524
X-RootMTR: 20171110173236epcas4p2e31777c5a06270f2aed64110fedf0524
References: <CGME20171110173236epcas4p2e31777c5a06270f2aed64110fedf0524@epcas4p2.samsung.com>
        <20171110173231.24598-1-colin.king@canonical.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, November 10, 2017 05:32:31 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer fbi is dereferenced with par = fbi->par before there is a
> null check on fbi, hence there is a potential null pointer dereference
> on a null par.  Fix this by moving the dereference after the null
> pointer check.
> 
> Detected by CoverityScan, CID#1461301 ("Dereference before null check")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics