From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C1DAC433E0 for ; Tue, 2 Jun 2020 15:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7EAD206E2 for ; Tue, 2 Jun 2020 15:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbgFBPak (ORCPT ); Tue, 2 Jun 2020 11:30:40 -0400 Received: from mga12.intel.com ([192.55.52.136]:16053 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgFBPaj (ORCPT ); Tue, 2 Jun 2020 11:30:39 -0400 IronPort-SDR: /IG68SwVwgXGShQyWxhrFQpbSBnjVN+av9WFZ+RYHP0a6IN3X5lkUS0lTxM8rVUo6hagyilDW3 cFDTYTOXBd8A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 08:30:26 -0700 IronPort-SDR: d5EdmYzh9a8PyRQSBpfkNaZ5Zx17bWFjOT8KVeU+Lrb7xj0hvAMCoxRMHpd0lWwK9Zpn3o7iNH 4LXThYfTl8Qw== X-IronPort-AV: E=Sophos;i="5.73,464,1583222400"; d="scan'208";a="257661820" Received: from ddalessa-mobl.amr.corp.intel.com (HELO [10.254.200.182]) ([10.254.200.182]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 08:30:15 -0700 Subject: Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() To: YueHaibing , mike.marciniszyn@intel.com, dledford@redhat.com, jgg@ziepe.ca, sadanand.warrier@intel.com, grzegorz.andrejczuk@intel.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com, kernel-janitors@vger.kernel.org References: <20200601135644.GD4872@ziepe.ca> <20200602061635.31224-1-yuehaibing@huawei.com> From: Dennis Dalessandro Message-ID: <75257c20-3cf2-7ecc-0d66-e1f4155ba105@intel.com> Date: Tue, 2 Jun 2020 11:30:13 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200602061635.31224-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/2020 2:16 AM, YueHaibing wrote: > dummy_netdev shold be freed by free_netdev() instead of > kfree(). Also remove unneeded variable 'priv' > > Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev") > Signed-off-by: YueHaibing > --- > drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c > index 58af6a454761..63688e85e8da 100644 > --- a/drivers/infiniband/hw/hfi1/netdev_rx.c > +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c > @@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd) > > void hfi1_netdev_free(struct hfi1_devdata *dd) > { > - struct hfi1_netdev_priv *priv; > - > if (dd->dummy_netdev) { > - priv = hfi1_netdev_priv(dd->dummy_netdev); > dd_dev_info(dd, "hfi1 netdev freed\n"); > - kfree(dd->dummy_netdev); > + free_netdev(dd->dummy_netdev); > dd->dummy_netdev = NULL; > } > } > For the kfree->free_netdev, you probably want to add: Reported-by: kbuild test robot Reported-by: Dan Carpenter Also can add: Reviewed-by: Dennis Dalessandro Thanks