From: Purva Yeshi <purvayeshi550@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Thinh.Nguyen@synopsys.com, skhan@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: Fix kernel-doc warning for sg member in
Date: Wed, 5 Feb 2025 19:47:51 +0530 [thread overview]
Message-ID: <752c6c87-567f-4569-8eda-2ca4d67211b3@gmail.com> (raw)
In-Reply-To: <2025020552-sandstorm-thaw-132e@gregkh>
On 05/02/25 10:57, Greg KH wrote:
> On Wed, Feb 05, 2025 at 02:15:08AM +0530, Purva Yeshi wrote:
>> On 04/02/25 19:15, Greg KH wrote:
>>> On Tue, Feb 04, 2025 at 07:14:23PM +0530, Purva Yeshi wrote:
>>>> Added description for the 'sg' member in struct dwc3_request to
>>>> resolve the kerneldoc warning when running 'make htmldocs'.
>>>>
>>>> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
>>>> ---
>>>> drivers/usb/dwc3/core.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>>>> index f11570c8ffd0..5e4daec322b7 100644
>>>> --- a/drivers/usb/dwc3/core.h
>>>> +++ b/drivers/usb/dwc3/core.h
>>>> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>>>> * @request: struct usb_request to be transferred
>>>> * @list: a list_head used for request queueing
>>>> * @dep: struct dwc3_ep owning this request
>>>> + * @sg: pointer to the scatter-gather list
>>>> * @start_sg: pointer to the sg which should be queued next
>>>> * @num_pending_sgs: counter to pending sgs
>>>> * @remaining: amount of data remaining
>>>> --
>>>> 2.34.1
>>>>
>>>
>>> What kernel version/tree did you make this change against?
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> The change was made against kernel version 6.13.0-rc7+.
>
> Please always work against the latest development tree for the subsystem
> you are working on, OR against linux-next, so that you don't end up
> duplicating work that others have already done, like was done here.
>
> thanks,
>
> greg k-h
Thanks for the feedback. I’ll use the latest development tree and make
sure to work against the right one next time.
Best regards,
Purva Yeshi
next prev parent reply other threads:[~2025-02-05 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:44 [PATCH] usb: dwc3: Fix kernel-doc warning for sg member in Purva Yeshi
2025-02-04 13:45 ` Greg KH
2025-02-04 20:45 ` Purva Yeshi
2025-02-05 5:27 ` Greg KH
2025-02-05 14:17 ` Purva Yeshi [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-04 9:15 Purva Yeshi
2025-02-04 13:27 ` Purva Yeshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=752c6c87-567f-4569-8eda-2ca4d67211b3@gmail.com \
--to=purvayeshi550@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox