Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles

Samuel Holland
2022-07-13T03:01:23Z

On 7/7/22 3:06 PM, Chanwoo Choi wrote:
> Hi Samuel,
>
> On 22. 7. 2. 13:24, Samuel Holland wrote:
>> All of the sunxi SoCs since at least the A33 have a similar structure
>> for the MBUS and DRAM controller, but they all have minor differences in
>> MBUS port assignments and DRAM controller behavior. Give each SoC its
>> own compatible.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>> ---
>>
>> .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> index 2b018feb56df..99566688d033 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> @@ -29,10 +29,20 @@ properties:
>> compatible:
>> enum:
>> - allwinner,sun5i-a13-mbus
>> + - allwinner,sun8i-a33-mbus
>> + - allwinner,sun8i-a50-mbus
>> + - allwinner,sun8i-a83t-mbus
>> - allwinner,sun8i-h3-mbus
>> - allwinner,sun8i-r40-mbus
>> + - allwinner,sun8i-v3s-mbus
>> + - allwinner,sun8i-v536-mbus
>> + - allwinner,sun20i-d1-mbus
>> - allwinner,sun50i-a64-mbus
>> + - allwinner,sun50i-a100-mbus
>> - allwinner,sun50i-h5-mbus
>> + - allwinner,sun50i-h6-mbus
>> + - allwinner,sun50i-h616-mbus
>> + - allwinner,sun50i-r329-mbus
>>
>> reg:
>> minItems: 1
>
> I have a question.
> Are there the device drivers for the newly added compatible?

There are not DVFS drivers yet. However, the nodes are needed for their
dma-ranges property, which affects some other devices that do have drivers. And
at least for D1, the MBUS node is used for U-Boot's DRAM driver.

Regards,
Samuel