Re: Re: [PATCH v6 11/18] input: Add initial support for TWL6040 vibrator

Péter Ujfalusi
2011-06-22T12:37:39Z

Hello Dmitry,

On Tuesday 21 June 2011 22:32:01 Dmitry Torokhov wrote:
> On Tue, Jun 21, 2011 at 04:39:09PM +0300, Peter Ujfalusi wrote:
> > From: Misael Lopez Cruz <misael.lopez@ti.com>
> >
> > Add twl6040_vibra as a child of MFD device twl6040_codec. This
> > implementation covers the PCM-to-PWM mode of TWL6040 vibrator
> > module.
> >
> > Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > CC: Tejun Heo <tj@kernel.org>
>
> Peter,
>
> As Tejun mentioned, there is no difference between having a "private"
> workqueue created with alloc_workqueue() with default parameters and
> using system-wide workqueue. Therefore please use system-wide one. If
> your use shows that you indeed need high-priority workqueue it can be
> added later.

I have replaced the singlethreaded wq with the call suggested by Tejun:
https://lkml.org/lkml/2011/6/17/99

If this is a problem, I can rework this, and remove the code, which is not
going to be needed, when the system_wq is in use, but I would like to keep the
alloc_workqueue way, since it is going to be easier for us to experiment with
parameters, if we face with issues.

> Otherwise:
>
> Acked-by: Dmitry Torokhov <dtor@mail.ru>
>
> Please feel free to merge this code with the rest of TWL6040 patches
> (presumably throgh Samuel's MFD tree).

Thank you,
Péter