Re: Re: [PATCH v6 08/18] mfd: twl6040: Add initial support

Felipe Balbi
2011-07-04T13:27:26Z

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Hi,

On Mon, Jul 04, 2011 at 04:09:30PM +0300, Péter Ujfalusi wrote:
> Hi Felipe, Samuel,
>
> On Monday 04 July 2011 14:53:30 Balbi, Felipe wrote:
> > > + ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY,
> > > + twl6040_naudint_handler, 0,
> > > + "twl6040_irq_ready", twl6040);
> >
> > why don't you use the normal request_threaded_irq() ?? This is a bit of
> > obfuscation IMO.
>
> I have left this 'macro' in since it is also used within the twl6040-vibra,
> and twl6040 ASoC codec driver to request the irq for them.
> But if you think it is better to replace the twl6040_request_irq with direct
> request_threaded_irq in those drivers as well, I'll do that.

IMO, yes it's better. But you can do it on a separate patch, of course
;-)

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]