* [PATCH] arch/sparc: fix unused vaiable warning error
@ 2026-01-07 6:42 alexs
2026-01-07 8:42 ` John Paul Adrian Glaubitz
0 siblings, 1 reply; 3+ messages in thread
From: alexs @ 2026-01-07 6:42 UTC (permalink / raw)
To: David S. Miller, Andreas Larsson,
open list:SPARC + UltraSPARC (sparc/sparc64), open list
Cc: linux-kernel, Alex Shi, kernel test robot, sparclinux,
Matthew Wilcox, Lorenzo Stoakes, Qi Zheng, Dave Hansen, Zi Yan,
Kevin Brodsky, Mike Rapoport, Andrew Morton
From: Alex Shi <alexs@kernel.org>
arch/sparc/mm/init_64.c: In function 'arch_hugetlb_valid_size':
arch/sparc/mm/init_64.c:361:24: warning: variable 'hv_pgsz_idx' set but not used [-Wunused-but-set-variable]
361 | unsigned short hv_pgsz_idx;
| ^~~~~~~~~~~
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alex Shi <alexs@kernel.org>
Cc: sparclinux@vger.kernel.org
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Larsson <andreas@gaisler.com>
Cc: David S. Miller <davem@davemloft.net>
---
arch/sparc/mm/init_64.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
index df9f7c444c39..ba19d23d4040 100644
--- a/arch/sparc/mm/init_64.c
+++ b/arch/sparc/mm/init_64.c
@@ -358,30 +358,24 @@ static void __init pud_huge_patch(void)
bool __init arch_hugetlb_valid_size(unsigned long size)
{
unsigned int hugepage_shift = ilog2(size);
- unsigned short hv_pgsz_idx;
unsigned int hv_pgsz_mask;
switch (hugepage_shift) {
case HPAGE_16GB_SHIFT:
hv_pgsz_mask = HV_PGSZ_MASK_16GB;
- hv_pgsz_idx = HV_PGSZ_IDX_16GB;
pud_huge_patch();
break;
case HPAGE_2GB_SHIFT:
hv_pgsz_mask = HV_PGSZ_MASK_2GB;
- hv_pgsz_idx = HV_PGSZ_IDX_2GB;
break;
case HPAGE_256MB_SHIFT:
hv_pgsz_mask = HV_PGSZ_MASK_256MB;
- hv_pgsz_idx = HV_PGSZ_IDX_256MB;
break;
case HPAGE_SHIFT:
hv_pgsz_mask = HV_PGSZ_MASK_4MB;
- hv_pgsz_idx = HV_PGSZ_IDX_4MB;
break;
case HPAGE_64K_SHIFT:
hv_pgsz_mask = HV_PGSZ_MASK_64K;
- hv_pgsz_idx = HV_PGSZ_IDX_64K;
break;
default:
hv_pgsz_mask = 0;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arch/sparc: fix unused vaiable warning error
2026-01-07 6:42 [PATCH] arch/sparc: fix unused vaiable warning error alexs
@ 2026-01-07 8:42 ` John Paul Adrian Glaubitz
2026-01-07 9:36 ` Alex Shi
0 siblings, 1 reply; 3+ messages in thread
From: John Paul Adrian Glaubitz @ 2026-01-07 8:42 UTC (permalink / raw)
To: alexs, David S. Miller, Andreas Larsson,
open list:SPARC + UltraSPARC (sparc/sparc64), open list
Cc: kernel test robot, Matthew Wilcox, Lorenzo Stoakes, Qi Zheng,
Dave Hansen, Zi Yan, Kevin Brodsky, Mike Rapoport, Andrew Morton
Hi Alex,
On Wed, 2026-01-07 at 14:42 +0800, alexs@kernel.org wrote:
> From: Alex Shi <alexs@kernel.org>
>
> arch/sparc/mm/init_64.c: In function 'arch_hugetlb_valid_size':
> arch/sparc/mm/init_64.c:361:24: warning: variable 'hv_pgsz_idx' set but not used [-Wunused-but-set-variable]
> 361 | unsigned short hv_pgsz_idx;
> | ^~~~~~~~~~~
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alex Shi <alexs@kernel.org>
> Cc: sparclinux@vger.kernel.org
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Qi Zheng <zhengqi.arch@bytedance.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Kevin Brodsky <kevin.brodsky@arm.com>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Larsson <andreas@gaisler.com>
> Cc: David S. Miller <davem@davemloft.net>
> ---
> arch/sparc/mm/init_64.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
> index df9f7c444c39..ba19d23d4040 100644
> --- a/arch/sparc/mm/init_64.c
> +++ b/arch/sparc/mm/init_64.c
> @@ -358,30 +358,24 @@ static void __init pud_huge_patch(void)
> bool __init arch_hugetlb_valid_size(unsigned long size)
> {
> unsigned int hugepage_shift = ilog2(size);
> - unsigned short hv_pgsz_idx;
> unsigned int hv_pgsz_mask;
>
> switch (hugepage_shift) {
> case HPAGE_16GB_SHIFT:
> hv_pgsz_mask = HV_PGSZ_MASK_16GB;
> - hv_pgsz_idx = HV_PGSZ_IDX_16GB;
> pud_huge_patch();
> break;
> case HPAGE_2GB_SHIFT:
> hv_pgsz_mask = HV_PGSZ_MASK_2GB;
> - hv_pgsz_idx = HV_PGSZ_IDX_2GB;
> break;
> case HPAGE_256MB_SHIFT:
> hv_pgsz_mask = HV_PGSZ_MASK_256MB;
> - hv_pgsz_idx = HV_PGSZ_IDX_256MB;
> break;
> case HPAGE_SHIFT:
> hv_pgsz_mask = HV_PGSZ_MASK_4MB;
> - hv_pgsz_idx = HV_PGSZ_IDX_4MB;
> break;
> case HPAGE_64K_SHIFT:
> hv_pgsz_mask = HV_PGSZ_MASK_64K;
> - hv_pgsz_idx = HV_PGSZ_IDX_64K;
> break;
> default:
> hv_pgsz_mask = 0;
Thanks for the patch! Could you fix the typo in the subject?
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arch/sparc: fix unused vaiable warning error
2026-01-07 8:42 ` John Paul Adrian Glaubitz
@ 2026-01-07 9:36 ` Alex Shi
0 siblings, 0 replies; 3+ messages in thread
From: Alex Shi @ 2026-01-07 9:36 UTC (permalink / raw)
To: John Paul Adrian Glaubitz, alexs, David S. Miller,
Andreas Larsson, open list:SPARC + UltraSPARC (sparc/sparc64),
open list
Cc: kernel test robot, Matthew Wilcox, Lorenzo Stoakes, Qi Zheng,
Dave Hansen, Zi Yan, Kevin Brodsky, Mike Rapoport, Andrew Morton
On 2026/1/7 16:42, John Paul Adrian Glaubitz wrote:
> Hi Alex,
>
> On Wed, 2026-01-07 at 14:42 +0800,alexs@kernel.org wrote:
>> From: Alex Shi<alexs@kernel.org>
>>
>> arch/sparc/mm/init_64.c: In function 'arch_hugetlb_valid_size':
>> arch/sparc/mm/init_64.c:361:24: warning: variable 'hv_pgsz_idx' set but not used [-Wunused-but-set-variable]
>> 361 | unsigned short hv_pgsz_idx;
>> | ^~~~~~~~~~~
>>
>> Reported-by: kernel test robot<lkp@intel.com>
>> Signed-off-by: Alex Shi<alexs@kernel.org>
>> Cc:sparclinux@vger.kernel.org
>> Cc: Matthew Wilcox<willy@infradead.org>
>> Cc: Lorenzo Stoakes<lorenzo.stoakes@oracle.com>
>> Cc: Qi Zheng<zhengqi.arch@bytedance.com>
>> Cc: Dave Hansen<dave.hansen@linux.intel.com>
>> Cc: Zi Yan<ziy@nvidia.com>
>> Cc: Kevin Brodsky<kevin.brodsky@arm.com>
>> Cc: Mike Rapoport<rppt@kernel.org>
>> Cc: Andrew Morton<akpm@linux-foundation.org>
>> Cc: Andreas Larsson<andreas@gaisler.com>
>> Cc: David S. Miller<davem@davemloft.net>
>> ---
>> arch/sparc/mm/init_64.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
>> index df9f7c444c39..ba19d23d4040 100644
>> --- a/arch/sparc/mm/init_64.c
>> +++ b/arch/sparc/mm/init_64.c
>> @@ -358,30 +358,24 @@ static void __init pud_huge_patch(void)
>> bool __init arch_hugetlb_valid_size(unsigned long size)
>> {
>> unsigned int hugepage_shift = ilog2(size);
>> - unsigned short hv_pgsz_idx;
>> unsigned int hv_pgsz_mask;
>>
>> switch (hugepage_shift) {
>> case HPAGE_16GB_SHIFT:
>> hv_pgsz_mask = HV_PGSZ_MASK_16GB;
>> - hv_pgsz_idx = HV_PGSZ_IDX_16GB;
>> pud_huge_patch();
>> break;
>> case HPAGE_2GB_SHIFT:
>> hv_pgsz_mask = HV_PGSZ_MASK_2GB;
>> - hv_pgsz_idx = HV_PGSZ_IDX_2GB;
>> break;
>> case HPAGE_256MB_SHIFT:
>> hv_pgsz_mask = HV_PGSZ_MASK_256MB;
>> - hv_pgsz_idx = HV_PGSZ_IDX_256MB;
>> break;
>> case HPAGE_SHIFT:
>> hv_pgsz_mask = HV_PGSZ_MASK_4MB;
>> - hv_pgsz_idx = HV_PGSZ_IDX_4MB;
>> break;
>> case HPAGE_64K_SHIFT:
>> hv_pgsz_mask = HV_PGSZ_MASK_64K;
>> - hv_pgsz_idx = HV_PGSZ_IDX_64K;
>> break;
>> default:
>> hv_pgsz_mask = 0;
> Thanks for the patch! Could you fix the typo in the subject?
Thanks a lot. I will update the subject and resend for v2.
Thanks
Alex
>
> Thanks,
> Adrian
>
> -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `'
> Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-07 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07 6:42 [PATCH] arch/sparc: fix unused vaiable warning error alexs
2026-01-07 8:42 ` John Paul Adrian Glaubitz
2026-01-07 9:36 ` Alex Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox