From: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
To: "Darren Hart (VMware)" <dvhart@infradead.org>
Cc: <platform-driver-x86@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
AceLan Kao <acelan.kao@canonical.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic
Date: Sat, 9 Dec 2017 00:28:18 +0100 [thread overview]
Message-ID: <7546133.vVTS3nG8Ku@pebbles> (raw)
In-Reply-To: <eb2e1de12dad4c11454b009075f916c63de8a2a6.1512774279.git.dvhart@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Saturday, December 9, 2017 12:07:08 AM CET Darren Hart (VMware) wrote:
> The new notify_handler logic determining if autorelease should be used or
> not is a bit awkward, and can result in more than one call to
> sparse_keymap_report_event for the same event (scancode). The nesting
> and long lines also made it difficult to read.
>
> Simplify the logic by eliminating a level of nesting with a goto and
> always calculate autorelease and val so we can make a single call to
> sparse_keymap_report_event.
>
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: Stefan Brüns <stefan.bruens@rwth-aachen.de>
> Cc: AceLan Kao <acelan.kao@canonical.com>
> ---
> Note: This is based on top of Stefan's v2 patch series for intel-vbtn,
> currently in my review-dvhart branch.
Hi Darren,
is this tree publically available?
Thanks,
Stefan
--
Stefan Brüns / Bergstraße 21 / 52062 Aachen
home: +49 241 53809034 mobile: +49 151 50412019
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-12-08 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 23:07 [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic Darren Hart (VMware)
2017-12-08 23:28 ` Stefan Brüns [this message]
2017-12-08 23:48 ` Darren Hart
2017-12-11 1:48 ` Stefan Brüns
2017-12-12 0:31 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7546133.vVTS3nG8Ku@pebbles \
--to=stefan.bruens@rwth-aachen.de \
--cc=acelan.kao@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox