From: Shuah Khan <skhan@linuxfoundation.org>
To: Yang Li <yang.lee@linux.alibaba.com>, shuah@kernel.org
Cc: tyhicks@linux.microsoft.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/ipc: remove unneeded semicolon
Date: Mon, 8 Feb 2021 16:33:54 -0700 [thread overview]
Message-ID: <75573614-2915-54fd-9da1-9d979feaae96@linuxfoundation.org> (raw)
In-Reply-To: <1612779840-77555-1-git-send-email-yang.lee@linux.alibaba.com>
On 2/8/21 3:24 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./tools/testing/selftests/ipc/msgque.c:72:3-4: Unneeded semicolon
> ./tools/testing/selftests/ipc/msgque.c:183:2-3: Unneeded semicolon
> ./tools/testing/selftests/ipc/msgque.c:191:2-3: Unneeded semicolon
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> tools/testing/selftests/ipc/msgque.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
> index 5ec4d9e..656c43c 100644
> --- a/tools/testing/selftests/ipc/msgque.c
> +++ b/tools/testing/selftests/ipc/msgque.c
> @@ -69,7 +69,7 @@ int restore_queue(struct msgque_data *msgque)
> printf("msgsnd failed (%m)\n");
> ret = -errno;
> goto destroy;
> - };
> + }
> }
> return 0;
>
> @@ -180,7 +180,7 @@ int fill_msgque(struct msgque_data *msgque)
> IPC_NOWAIT) != 0) {
> printf("First message send failed (%m)\n");
> return -errno;
> - };
> + }
>
> msgbuf.mtype = ANOTHER_MSG_TYPE;
> memcpy(msgbuf.mtext, ANOTHER_TEST_STRING, sizeof(ANOTHER_TEST_STRING));
> @@ -188,7 +188,7 @@ int fill_msgque(struct msgque_data *msgque)
> IPC_NOWAIT) != 0) {
> printf("Second message send failed (%m)\n");
> return -errno;
> - };
> + }
> return 0;
> }
>
>
Thank you. Now applied to linux-kselftest next for 5.12-rc1
thanks,
-- Shuah
prev parent reply other threads:[~2021-02-08 23:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 10:24 [PATCH] selftests/ipc: remove unneeded semicolon Yang Li
2021-02-08 23:33 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75573614-2915-54fd-9da1-9d979feaae96@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tyhicks@linux.microsoft.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox